Project

General

Profile

action #90614

CI test webui-docker-compose failed but PR was merged anyway

Added by okurz 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
2021-04-01
Due date:
2021-04-23
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

https://github.com/os-autoinst/openQA/pull/3820 showed that the CI check "webui-docker-compose" failed (problem Nr. 1) but mergify nevertheless merged the PR (problem Nr. 2)

Acceptance criteria

  • AC1: webui-docker-compose is stable
  • AC2: mergify only merges if also webui-docker-compose (and likely others?) are passed

Suggestions

The command '/bin/sh -c zypper ar -p 95 -f http://download.opensuse.org/repositories/devel:openQA/openSUSE_Leap_15.2 devel_openQA &&     zypper ar -p 90 -f http://download.opensuse.org/repositories/devel:openQA:Leap:15.2/openSUSE_Leap_15.2 devel_openQA_Leap &&     zypper --gpg-auto-import-keys ref &&     zypper in -y --force-resolution openQA nginx &&     zypper clean' returned a non-zero code: 8
  • Make sure that such failure is handled with retry
  • Add this check and potentially others to the mergify config so that mergify does not merge prematurely

Related issues

Related to openQA Project - action #91046: CI: "webui-docker-compose" seems that eventually fails againResolved2021-04-13

Related to openQA Project - action #91097: CI: "webui-docker-compose" eventually fails building imagesResolved2021-04-142021-04-29

History

#1 Updated by ilausuch 4 months ago

  • Assignee set to ilausuch

#2 Updated by ilausuch 4 months ago

  • Status changed from Workable to In Progress

#3 Updated by openqa_review 4 months ago

  • Due date set to 2021-04-23

Setting due date based on mean cycle time of SUSE QE Tools

#5 Updated by cdywan 3 months ago

  • Status changed from In Progress to Feedback

mkittler wrote:

PR: https://github.com/os-autoinst/openQA/pull/3831

PR approved and merged

#6 Updated by okurz 3 months ago

So AC2 is covered, what about AC1?

#7 Updated by ilausuch 3 months ago

Should be with #91046

#8 Updated by ilausuch 3 months ago

  • Related to action #91046: CI: "webui-docker-compose" seems that eventually fails again added

#9 Updated by ilausuch 3 months ago

However some zypper problems has being detected #90614

#10 Updated by ilausuch 3 months ago

  • Related to action #91097: CI: "webui-docker-compose" eventually fails building images added

#11 Updated by ilausuch 3 months ago

I create a new PR to ensure 3 retries to docker-compose build
https://github.com/os-autoinst/openQA/pull/3844

#12 Updated by ilausuch 3 months ago

  • Status changed from Feedback to In Progress

#13 Updated by ilausuch 3 months ago

I think we can consider this as done

#14 Updated by ilausuch 3 months ago

  • Status changed from In Progress to Resolved

All the AC are covered

AC1: webui-docker-compose is stable
Is covered by https://github.com/os-autoinst/openQA/pull/3844 (CI: Retry if docker-compose build fails in webui-docker-compose test)
And https://github.com/os-autoinst/openQA/pull/3840 (https://github.com/os-autoinst/openQA/pull/3840)

AC2: mergify only merges if also webui-docker-compose (and likely others?) are passed
Is covered by https://github.com/os-autoinst/openQA/pull/3831/files (CI: Add checks over static-check-containers and webui-docker-compose in mergify)

Also available in: Atom PDF