action #88482: Two absolute paths concatenated to form a default needle dir when PRODUCT_DIR/needles doesn't exist - openQA Project - openSUSE Project Management Tool

Actions

Copy link

action #88482

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #80372: [epic] Cleanup vars.json as initial information container between openQA worker and isotovideo

Two absolute paths concatenated to form a default needle dir when PRODUCT_DIR/needles doesn't exist

Added by ilausuch about 3 years ago. Updated almost 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Xiaojing_liu

Category:

Regressions/Crashes

Target version:

Ready

Start date:

2021-02-08

Due date:

% Done:

Estimated time:

6.00 h

Description

Observation¶

Sometimes a job execution fails with this error

needles_dir not found: /var/lib/openqa/share/tests/opensuse/var/lib/openqa/share/tests/opensuse/products/opensuse/needles (check vars.json?) at /usr/lib/os-autoinst/needle.pm line 330.

Is concatenating two absolute paths (https://github.com/os-autoinst/os-autoinst/blob/adbb28bc61ce4f21a55d07399eac7d48badc6b6f/needle.pm#L328) when needles directory doesn't exist.

Reproduction¶

Remove the directory needles from /var/lib/openqa/share/tests/opensuse/products/opensuse

Acceptance criteria¶

AC1: Needles folder has a working default or aborts if PRODUCT_DIR/needles doesn't exist

Suggestions¶

Look into logic in needle.pm
Improve error message to reveal relevant variables instead of hinting at vars.json i.e. NEEDLES_DIR, CASEDIR and default_needles_dir
Log the missing PRODUCTDIR}/needles if this affects the default nedles folder to be used here

Work-around¶

Create a folder PRODUCTDIR}/needles

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by livdywan about 3 years ago

Subject changed from Improve the error when the needles directory doesn't exist to Two absolute paths concatenated to form a default needle dir when PRODUCT_DIR/needles doesn't exist
Description updated (diff)
Category set to Regressions/Crashes
Status changed from New to Workable

Updated the description and title. To my mind, this path default makes no sense. The error could be more helpful, but it should be clear that this isn't just a cosmetic issue.

Actions

Copy link

Updated by livdywan about 3 years ago

Description updated (diff)

Actions

Copy link

Updated by okurz about 3 years ago

Target version set to future

Actions

Copy link

Updated by livdywan about 3 years ago

https://github.com/os-autoinst/os-autoinst/pull/1627

Actions

Copy link

Updated by okurz about 3 years ago

Related to coordination #67723: [epic] Remote openQA worker fails to run tests from openqa-clone-custom-git-refspec added

Actions

Copy link

Updated by okurz about 3 years ago

Status changed from Workable to In Progress
Assignee set to Xiaojing_liu
Target version changed from future to Ready

oh right. Cool that you found the relation. Then let's add that as related to the existing story.

@Xiaojing_liu I added you as assignee as you are already working on this topic with https://github.com/os-autoinst/os-autoinst/pull/1627 . Feel free to unassign again in case you or we find out that your PR will not fix the original problem or not all of it.

Actions

Copy link

Updated by okurz about 3 years ago

Parent task set to #80372

Actions

Copy link

Updated by openqa_review about 3 years ago

Due date set to 2021-03-12

Setting due date based on mean cycle time of SUSE QE Tools

Actions

Copy link

Updated by livdywan about 3 years ago

The PR got merged. The AC I proposed originally asks for a different solution but I'd say we can regard this as a fix. Users won't run into the error.

Actions

Copy link

#10