Project

General

Profile

action #88482

Updated by cdywan 7 months ago

## Observation
Sometimes a job execution fails with this error
```
needles_dir not found: /var/lib/openqa/share/tests/opensuse/var/lib/openqa/share/tests/opensuse/products/opensuse/needles (check vars.json?) at /usr/lib/os-autoinst/needle.pm line 330.
```
Is concatenating two absolute paths (https://github.com/os-autoinst/os-autoinst/blob/adbb28bc61ce4f21a55d07399eac7d48badc6b6f/needle.pm#L328) when needles directory doesn't exist.

## Reproduction
Remove the directory needles from /var/lib/openqa/share/tests/opensuse/products/opensuse

## Acceptance criteria
* AC1: Needles folder has a working default when PRODUCT_DIR/needles doesn't exist

## Suggestions
* Look into logic in `needle.pm`
*
Improve the error message to reveal relevant variables instead of hinting at `vars.json` i.e. `NEEDLES_DIR`, `CASEDIR` and `default_needles_dir`
* Log
showing that the missing `PRODUCTDIR}/needles` if this affects the default nedles folder to be used here needles directory doesn't exist

Back