QA » openQA Project

Hi,
I did an investigation about check dockerfiles and docker-compose files. These are the conclusions

To check the Dockerfile I fond and tested (https://github.com/hadolint/hadolint) This works within a container so we don't need to install extra things

docker run --rm -i hadolint/hadolint <Dockerfile

To check a docker-compose file the best option is to trust the docker-compose itself

docker-compose config

ilausuch wrote:

Hi,
I did an investigation about check dockerfiles and docker-compose files. These are the conclusions

To check the Dockerfile I fond and tested (https://github.com/hadolint/hadolint) This works within a container so we don't need to install extra things

docker run --rm -i hadolint/hadolint <Dockerfile

To check a docker-compose file the best option is to trust the docker-compose itself

There is hadolint on GHA. Although on os-autoinst we have a custom setup with a shellscript.

I kinda like actions that we can use as-is so we don't have to add more custom scripts - but we may want to document the reproducer i.e. the command you gave above since it should be as easy as possible to verify things locally if something fails in CI.

docker-compose config

I would lean towards running compose up and adding health checks. @ilausuch confirmed in chat that the static checks are always executed there, too.