action #71596
open[sle][qe-core] Extract virt_utils::lpar_cmd to avoid cyclic dependencies
0%
Description
Observation¶
In this pr a virt_utils was imported, to be able to call lpar_cmd however this introduced a circular dependency, leading to CI failures about redefined subroutine
For now the solution has been the same as before, do a static call
virt_utils::lpar_cmd("$test_cmd");
However, to avoid this problem happening in the future, I suggest to:
- Extract lpar_cmd to it's own package, or extract it to the utils package, right under utils::type_line_svirt (and adding a small documentation for the new routine :))
Updated by leli almost 3 years ago
Hi szarate, I can't see this is related with migration, can you remove the tag of [migration]?
Updated by szarate over 2 years ago
- Subject changed from [sle][migration] Extract virt_utils::lpar_cmd to avoid cyclic dependencies to [sle][qe-core] Extract virt_utils::lpar_cmd to avoid cyclic dependencies
leli wrote:
Hi szarate, I can't see this is related with migration, can you remove the tag of [migration]?
Correct my friend, when I created it, I saw it as a byproduct of work from the migration team, but since it lost relevance, well here we are :). I'll move it to qe-core
Updated by livdywan over 1 year ago
This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
Updated by slo-gin about 1 month ago
This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.