Project

General

Profile

Actions
Copy link

action #68702

closed

coordination #6558: [epic] add/edit/remove users

Add UI support for removing users

Added by okurz over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Low
Assignee:
ilausuch
Category:
Feature requests
Target version:
QA (public) - future
Start date:
2020-07-07
Due date:
% Done:

0%

Estimated time:

Description

Acceptance criteria

  • AC1: Admins can remove users over the webUI
  • AC2: Non-admins can not remove users

Suggestions

  • add interface to remove users

Related issues 1 (0 open — 1 closed)

Copied to openQA Project (public) - action #68705: Add webAPI support for removing usersResolvedilausuch2020-07-07

Actions
Actions
Copy link
 #1

Updated by okurz over 4 years ago

  • Copied to action #68705: Add webAPI support for removing users added
Actions
Copy link
 #2

Updated by ilausuch over 4 years ago

  • Status changed from Workable to Blocked
Actions
Copy link
 #3

Updated by okurz over 4 years ago

Hi, please only use "Blocked" with an assignee that tracks the blocker and also make sure the blocker is obvious. What do you feel this ticket is blocked by?

Actions
Copy link
 #4

Updated by livdywan over 4 years ago

I expect #68705 has to be implemented first since that would be used to implement the UI.

Actions
Copy link
 #5

Updated by ilausuch over 4 years ago

https://github.com/os-autoinst/openQA/pull/3247
I think I implemented both at the same time

Actions
Copy link
 #6

Updated by okurz over 4 years ago

  • Status changed from Blocked to In Progress
  • Assignee set to okurz

ok, you can track the ticket as assignee then. And as described in before the status "Blocked" is not good without an obvious reason but now "In Progress" matches.

Actions
Copy link
 #7

Updated by okurz over 4 years ago

  • Assignee changed from okurz to ilausuch

oops, that should have been ilausuch :)

Actions
Copy link
 #8

Updated by okurz over 4 years ago

The current PR https://github.com/os-autoinst/openQA/pull/3247 now should aim for deleting the user when there are no relations pending in the DB . As a followup we could consider https://github.com/os-autoinst/openQA/pull/3247#issuecomment-659453683 and ensure the user can be deleted in these cases as well and replace the references in DB accordingly. But I actually opt for even not doing that to keep the information also in audit log intact to prevent the missing information on "who did what".

Actions
Copy link
 #9

Updated by livdywan over 4 years ago

okurz wrote:

The current PR https://github.com/os-autoinst/openQA/pull/3247 now should aim for deleting the user when there are no relations pending in the DB . As a followup we could consider https://github.com/os-autoinst/openQA/pull/3247#issuecomment-659453683 and ensure the user can be deleted in these cases as well and replace the references in DB accordingly. But I actually opt for even not doing that to keep the information also in audit log intact to prevent the missing information on "who did what".

As it is you have to delete all events the user is involved in to delete them. So the "who" is definitely lost.
I would suggest we allow clearing the user details without dropping the user so the audit events can remain.

Actions
Copy link
 #10

Updated by okurz over 4 years ago

  • Status changed from In Progress to Resolved

This is why I meant to not do anything and keep it as is. We have support to delete unlinked users and IMHO we can live with that until someone external asks for more :)

@ilausuch not sure what other work if any you have planned for this as you have not provided a comment but I think we can set the specific task with the mentioned limited to "Resolved" here

Actions
Copy link

Also available in: Atom PDF