Project

General

Profile

action #68702

coordination #6558: [epic] add/edit/remove users

Add UI support for removing users

Added by okurz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
2020-07-07
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Acceptance criteria

  • AC1: Admins can remove users over the webUI
  • AC2: Non-admins can not remove users

Suggestions

  • add interface to remove users

Related issues

Copied to openQA Project - action #68705: Add webAPI support for removing usersResolved2020-07-07

History

#1 Updated by okurz about 1 year ago

  • Copied to action #68705: Add webAPI support for removing users added

#2 Updated by ilausuch about 1 year ago

  • Status changed from Workable to Blocked

#3 Updated by okurz about 1 year ago

Hi, please only use "Blocked" with an assignee that tracks the blocker and also make sure the blocker is obvious. What do you feel this ticket is blocked by?

#4 Updated by cdywan about 1 year ago

I expect #68705 has to be implemented first since that would be used to implement the UI.

#5 Updated by ilausuch about 1 year ago

https://github.com/os-autoinst/openQA/pull/3247
I think I implemented both at the same time

#6 Updated by okurz about 1 year ago

  • Status changed from Blocked to In Progress
  • Assignee set to okurz

ok, you can track the ticket as assignee then. And as described in before the status "Blocked" is not good without an obvious reason but now "In Progress" matches.

#7 Updated by okurz about 1 year ago

  • Assignee changed from okurz to ilausuch

oops, that should have been ilausuch :)

#8 Updated by okurz about 1 year ago

The current PR https://github.com/os-autoinst/openQA/pull/3247 now should aim for deleting the user when there are no relations pending in the DB . As a followup we could consider https://github.com/os-autoinst/openQA/pull/3247#issuecomment-659453683 and ensure the user can be deleted in these cases as well and replace the references in DB accordingly. But I actually opt for even not doing that to keep the information also in audit log intact to prevent the missing information on "who did what".

#9 Updated by cdywan about 1 year ago

okurz wrote:

The current PR https://github.com/os-autoinst/openQA/pull/3247 now should aim for deleting the user when there are no relations pending in the DB . As a followup we could consider https://github.com/os-autoinst/openQA/pull/3247#issuecomment-659453683 and ensure the user can be deleted in these cases as well and replace the references in DB accordingly. But I actually opt for even not doing that to keep the information also in audit log intact to prevent the missing information on "who did what".

As it is you have to delete all events the user is involved in to delete them. So the "who" is definitely lost.
I would suggest we allow clearing the user details without dropping the user so the audit events can remain.

#10 Updated by okurz about 1 year ago

  • Status changed from In Progress to Resolved

This is why I meant to not do anything and keep it as is. We have support to delete unlinked users and IMHO we can live with that until someone external asks for more :)

ilausuch not sure what other work if any you have planned for this as you have not provided a comment but I think we can set the specific task with the mentioned limited to "Resolved" here

Also available in: Atom PDF