Project

General

Profile

Actions
Copy link

action #64412

closed

coordination #154768: [saga][epic][ux] State-of-art user experience for openQA

coordination #154771: [epic] Improved test developer user experience

Get rid of eval in OpenQA::WebAPI::Plugin::HashedParams

Added by tinita over 4 years ago. Updated 29 days ago.

Status:
Resolved
Priority:
Low
Assignee:
dheidler
Category:
Feature requests
Target version:
Ready
Start date:
2020-03-11
Due date:
% Done:

0%

Estimated time:

Description

Problem

This plugin is a helper to receive nested data structures, as it can turn query parameters like

"settings[FOO][BAR]=baz"

into a data structure.

It is used only in the OpenQA::WebAPI::Controller::API::V1::Table.

The code removes unsafe characters and creates perl code which is then loaded with eval.

Suggestion

  1. The code could probably be replaced without eval, so we wouldn't need to clean the input.
  2. The Table API endpoints could also be changed to accept JSON instead, and we could get rid of the whole module.

Related issues 1 (0 open — 1 closed)

Related to openQA Project - action #166310: Replace jquery ajax calls with fetch API size:MResolveddheidler2024-09-04

Actions
Actions
Copy link

Also available in: Atom PDF