action #59852
closed
auto_review:"Failed to find an available port: Address already in use" Fix issues in Mojo::IOLoop::ReadWriteProcess leading to broken workers due to leftover QEMU processes
Added by mkittler over 4 years ago.
Updated almost 4 years ago.
Category:
Regressions/Crashes
Description
The worker's logic to prevent job execution when the QEMU from the previous test run hasn't been terminated was broken (see #56993).
This has already been fixed but showed that Mojo::IOLoop::ReadWriteProcess is unable to stop QEMU in all cases. Even with version 0.24 I could reproduce that very sporadic issue (on my Tumbleweed system).
I also observed that the CGroup feature might be broken, see my comment in #56993:
With this fix it at least creates the cgroup and passes it to the Mojo::IOLoop::ReadWriteProcess::Container thing. But I've just checked whether this has any actual influence on the cgroup tree (systemd-cgls) but it seems isotovideo and its forks including QEMU are just within the usual session-2.scope.
The could be the cause why Mojo::IOLoop::ReadWriteProcess is sometimes unable to stop QEMU.
- Subject changed from Identify and fix issues of Mojo::IOLoop::ReadWriteProcess to Fix issues of in Mojo::IOLoop::ReadWriteProcess leading to "broken" workers due to leftover QEMU processes
- Description updated (diff)
- Subject changed from Fix issues of in Mojo::IOLoop::ReadWriteProcess leading to "broken" workers due to leftover QEMU processes to Fix issues in Mojo::IOLoop::ReadWriteProcess leading to "broken" workers due to leftover QEMU processes
- Subject changed from Fix issues in Mojo::IOLoop::ReadWriteProcess leading to "broken" workers due to leftover QEMU processes to auto_review:"Failed to find an available port: Address already in use" Fix issues in Mojo::IOLoop::ReadWriteProcess leading to "broken" workers due to leftover QEMU processes
- Subject changed from auto_review:"Failed to find an available port: Address already in use" Fix issues in Mojo::IOLoop::ReadWriteProcess leading to "broken" workers due to leftover QEMU processes to auto_review:"Failed to find an available port: Address already in use" Fix issues in Mojo::IOLoop::ReadWriteProcess leading to broken workers due to leftover QEMU processes
- Status changed from New to Resolved
- Assignee set to okurz
We haven't seen this for long also after we worked on proper termination of processes. And also even more so mkittler recently did related changes as well that can help in this direction: https://github.com/os-autoinst/os-autoinst/pull/1439
So I consider this resolved.
Also available in: Atom
PDF