action #56813

START_AFTER_TEST dependency error should use `@$MACHINE` syntax

Added by cdywan 7 months ago. Updated 4 months ago.

Status:ResolvedStart date:11/09/2019
Priority:HighDue date:
Assignee:mkittler% Done:

0%

Category:Concrete Bugs
Target version:Done
Difficulty:medium
Duration:

Description

Reading this message, and considering I was investigating failures to do with replacing test suites with @staging or _staging in the name with parametrized ones, I was mildly confused:

START_AFTER_TEST=RAID0:64bit-staging not found - check for dependency typos and dependency cycles

I feel like this should be RAID0@64bit-staging using an @ rather than a : to separate the name of the test from the machine. This is how it's displayed elsewhere.


Related issues

Related to openQA Project - action #59082: Dependency graph shows just test name (misses machine) Resolved 05/11/2019

History

#1 Updated by cdywan 7 months ago

Apparently the docs on Inter-machine dependencies specify a :.

#2 Updated by coolo 6 months ago

  • Category set to Concrete Bugs
  • Target version set to Ready
  • Difficulty set to easy

#3 Updated by coolo 5 months ago

  • Priority changed from Normal to High
  • Difficulty changed from easy to medium

As we also use this for input, we need to write a migration and we really should do this rather soon before it spreads. So raising Difficulty and Priority

#4 Updated by coolo 5 months ago

  • Related to action #59082: Dependency graph shows just test name (misses machine) added

#5 Updated by mkittler 5 months ago

  • Assignee set to mkittler
  • Target version changed from Ready to Current Sprint

@coolo Because you added the relation to the dependency graph: The dependency graph doesn't show the machine within the tool tip which shows START_AFTER_TEST and the other variables. That is because the graph relies on the job dependencies database table which doesn't contain the original specification anymore. However, it would be possible to show the variables as specified from the job settings table.

#6 Updated by coolo 5 months ago

I don't follow - can you provide examples?

#7 Updated by mkittler 5 months ago

  • Status changed from New to In Progress

PR: https://github.com/os-autoinst/openQA/pull/2483

@coolo Consider tooltip of this job within its dependency tree: https://openqa.suse.de/tests/3548056#dependencies
The tooltip shows STARTS_AFTER_TEST=skip_registration but as visible in the job settings it was actually specified as START_AFTER_TEST=skip_registration:64bit. So unless we decide to display the variable from the job settings here (instead of making things up from the dependencies table) the issues aren't affecting each other. Not that I thought https://progress.opensuse.org/issues/59082 was only about the test name anyways (and not the dependency specification).

#8 Updated by coolo 5 months ago

the relation of the ticket is mainly to make sure we use @ everywhere

#9 Updated by mkittler 5 months ago

The PR has been merged. But do we actually need a migration? The backwards compatible parsing should just work.

#10 Updated by coolo 5 months ago

I would like to see at least a migration of our job groups to settle on @ - that doesn't need to be in git

#11 Updated by okurz 5 months ago

  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/openQA/pull/2522 includes an automatic migration.

@mkittler if you plan to do anything more feel free to set back to "In Progress".

#12 Updated by mkittler 4 months ago

  • Status changed from Feedback to Resolved
  • Target version changed from Current Sprint to Done

I've checked OSD and it is deployed and migrated.

Also available in: Atom PDF