action #56813
closedSTART_AFTER_TEST dependency error should use `@$MACHINE` syntax
Description
Reading this message, and considering I was investigating failures to do with replacing test suites with @staging or _staging in the name with parametrized ones, I was mildly confused:
START_AFTER_TEST=RAID0:64bit-staging not found - check for dependency typos and dependency cycles
I feel like this should be RAID0@64bit-staging using an @ rather than a : to separate the name of the test from the machine. This is how it's displayed elsewhere.
Updated by livdywan over 5 years ago
Apparently the docs on Inter-machine dependencies specify a :.
Updated by coolo about 5 years ago
- Category set to Regressions/Crashes
- Target version set to Ready
- Difficulty set to easy
Updated by coolo about 5 years ago
- Priority changed from Normal to High
- Difficulty changed from easy to medium
As we also use this for input, we need to write a migration and we really should do this rather soon before it spreads. So raising Difficulty and Priority
Updated by coolo about 5 years ago
- Related to action #59082: Dependency graph shows just test name (misses machine) added
Updated by mkittler about 5 years ago
- Assignee set to mkittler
- Target version changed from Ready to Current Sprint
@coolo Because you added the relation to the dependency graph: The dependency graph doesn't show the machine within the tool tip which shows START_AFTER_TEST and the other variables. That is because the graph relies on the job dependencies database table which doesn't contain the original specification anymore. However, it would be possible to show the variables as specified from the job settings table.
Updated by mkittler about 5 years ago
- Status changed from New to In Progress
PR: https://github.com/os-autoinst/openQA/pull/2483
@coolo Consider tooltip of this job within its dependency tree: https://openqa.suse.de/tests/3548056#dependencies
The tooltip shows STARTS_AFTER_TEST=skip_registration but as visible in the job settings it was actually specified as START_AFTER_TEST=skip_registration:64bit. So unless we decide to display the variable from the job settings here (instead of making things up from the dependencies table) the issues aren't affecting each other. Not that I thought https://progress.opensuse.org/issues/59082 was only about the test name anyways (and not the dependency specification).
Updated by coolo about 5 years ago
the relation of the ticket is mainly to make sure we use @ everywhere
Updated by mkittler about 5 years ago
The PR has been merged. But do we actually need a migration? The backwards compatible parsing should just work.
Updated by coolo about 5 years ago
I would like to see at least a migration of our job groups to settle on @ - that doesn't need to be in git
Updated by okurz about 5 years ago
- Status changed from In Progress to Feedback
https://github.com/os-autoinst/openQA/pull/2522 includes an automatic migration.
@mkittler if you plan to do anything more feel free to set back to "In Progress".
Updated by mkittler about 5 years ago
- Status changed from Feedback to Resolved
- Target version changed from Current Sprint to Done
I've checked OSD and it is deployed and migrated.