Project

General

Profile

Actions
Copy link

action #52673

closed

os-autoinst: Do not save "lastgood" snapshot on last module unless img is preserved with snapshot (e.g. --no-cleanup)

Added by okurz over 5 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
favogt
Category:
Feature requests
Target version:
QA (public) - future
Start date:
2019-06-06
Due date:
% Done:

0%

Estimated time:

Description

Motivation

it feels a bit wasteful to record snapshots just before successfully finishing a test that prunes the worker pool directory just afterwards:

[2019-06-05T21:52:34.455 CEST] [debug] ||| finished first_boot installation at 2019-06-05 19:52:34 (37 s)
[2019-06-05T21:52:34.456 CEST] [debug] Creating a VM snapshot lastgood
…
[2019-06-05T21:52:35.000 CEST] [debug] Migrating total bytes:       2152538112
[2019-06-05T21:52:35.000 CEST] [debug] Migrating remaining bytes:       2130817024

Suggestion

The snapshot is recorded because of the module "first_boot" being a "milestone" module. One idea is that the milestone flag would not make sense on the last module of a test job and should be ignored by os-autoinst for recording a snapshot "lastgood" unless MAKE_TEST_SNAPSHOTS=1 is set which would create a named snapshot but also unless the worker is started with "--no-cleanup" which we can not currently know from within os-autoinst.

Related issues 2 (0 open — 2 closed)

Related to openQA Project (public) - action #52451: test incompletes reproducibly in first_boot of krypton-live-install with "Seems like os-autoinst has produced a result which openQA can not display."Resolvedokurz2019-05-31

Actions
Related to openQA Tests (public) - action #69432: test fails with no module details after boot_ltp, broken run-time scheduling?Resolvedokurz2020-07-29

Actions
Actions
Copy link

Also available in: Atom PDF