os-autoinst: Do not save "lastgood" snapshot on last module unless img is preserved with snapshot (e.g. --no-cleanup)
it feels a bit wasteful to record snapshots just before successfully finishing a test that prunes the worker pool directory just afterwards:
[2019-06-05T21:52:34.455 CEST] [debug] ||| finished first_boot installation at 2019-06-05 19:52:34 (37 s) [2019-06-05T21:52:34.456 CEST] [debug] Creating a VM snapshot lastgood … [2019-06-05T21:52:35.000 CEST] [debug] Migrating total bytes: 2152538112 [2019-06-05T21:52:35.000 CEST] [debug] Migrating remaining bytes: 2130817024
The snapshot is recorded because of the module "first_boot" being a "milestone" module. One idea is that the milestone flag would not make sense on the last module of a test job and should be ignored by os-autoinst for recording a snapshot "lastgood" unless
MAKE_TEST_SNAPSHOTS=1 is set which would create a named snapshot but also unless the worker is started with "--no-cleanup" which we can not currently know from within os-autoinst.
- Status changed from New to In Progress
- Assignee set to favogt
favogt you are about to fix that with your PR https://github.com/os-autoinst/os-autoinst/pull/1483
- Status changed from Resolved to Feedback
problems found by OSD users: #69432 . The same problem has been present on o3 but unfortunately not been handled.
favogt I revert the change with https://github.com/os-autoinst/os-autoinst/pull/1490 to handle the problem as soon as possible. Hopefully we can bring back this change and have that problem fixed as well. Would you be happy to give it another shot? #69432 also mentions a good and fast test case that you could use to bisect what part of the change breaks it. I am sure mdoucha can also give helpful support.
updated PR by favogt: https://github.com/os-autoinst/os-autoinst/pull/1492