Project

General

Profile

Actions
Copy link

action #52490

closed

Yaml appears in every jobtemplate_create audit log

Added by coolo almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
livdywan
Category:
Feature requests
Target version:
Current Sprint
Start date:
2019-06-03
Due date:
% Done:

100%

Estimated time:

Description

This might be temporary, but if you click in the job template config, every event will store the full yaml in the audit log.

It would be better to store the text diff as part of the event (or find a similiar representation of the change)

Actions
Copy link
 #1

Updated by mkittler almost 5 years ago

I wanted to check this for myself but it seems you already cleaned up all jobtemplate_create events on OSD.

Here's a fix for the immediate problem: https://github.com/os-autoinst/openQA/pull/2087

@cdywan Do you want to work on this? Otherwise I pick it. (I can't work on the worker all the time.)

Actions
Copy link
 #2

Updated by coolo almost 5 years ago

I didn't clean up anything

Actions
Copy link
 #3

Updated by livdywan almost 5 years ago

@mkittler Thanks for the quick fix!
I will look into the diff for a proper fix for this when looking at conflict handling (ie. overlapping updates to the same yaml).

Actions
Copy link
 #4

Updated by okurz almost 5 years ago

  • Assignee set to livdywan

so as the PR is merged and cdywan will do the next steps I guess I can assign to you accordingly?

Actions
Copy link
 #6

Updated by livdywan almost 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF