Project

General

Profile

action #52490

Yaml appears in every jobtemplate_create audit log

Added by coolo about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2019-06-03
Due date:
% Done:

100%

Estimated time:
Difficulty:
Duration:

Description

This might be temporary, but if you click in the job template config, every event will store the full yaml in the audit log.

It would be better to store the text diff as part of the event (or find a similiar representation of the change)

History

#1 Updated by mkittler about 1 year ago

I wanted to check this for myself but it seems you already cleaned up all jobtemplate_create events on OSD.

Here's a fix for the immediate problem: https://github.com/os-autoinst/openQA/pull/2087

cdywan Do you want to work on this? Otherwise I pick it. (I can't work on the worker all the time.)

#2 Updated by coolo about 1 year ago

I didn't clean up anything

#3 Updated by cdywan about 1 year ago

mkittler Thanks for the quick fix!
I will look into the diff for a proper fix for this when looking at conflict handling (ie. overlapping updates to the same yaml).

#4 Updated by okurz about 1 year ago

  • Assignee set to cdywan

so as the PR is merged and cdywan will do the next steps I guess I can assign to you accordingly?

#6 Updated by cdywan about 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF