Project

General

Profile

action #44039

/admin/test_suites is broken without login

Added by coolo almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
2018-11-20
Due date:
% Done:

0%

Estimated time:
Difficulty:
easy

Description

The page doesn't show a 403 (I guess it should), but just barfs in javascript because:

Uncaught SyntaxError: Unexpected token ,

History

#1 Updated by coolo almost 2 years ago

  • Project changed from openQA Tests to openQA Project
  • Category set to Concrete Bugs

#2 Updated by mkittler almost 2 years ago

I guess it should

I remember doing a ticket which was about making admin pages publicly available in read-only mode. This would revert that effort. Likely fixing the JavaScript error is not a big deal so I'd say fix the error and keep the page publicly accessible.

#3 Updated by okurz almost 2 years ago

+1

#4 Updated by kraih almost 2 years ago

  • Status changed from New to In Progress

Fixing the JavaScript seems easy enough. There are three more uses of <%= is_admin %> that look really sketchy. Any pointers where a test for this could go?

#5 Updated by coolo almost 2 years ago

I guess this is a good oportunity to get familiar with selenium - t/ui/13-admin.t logs in as first step. To test this, there needs to either an extra test file or more subtests before login

#6 Updated by kraih almost 2 years ago

  • Status changed from In Progress to Resolved

#7 Updated by coolo over 1 year ago

  • Target version changed from Ready to Done

Also available in: Atom PDF