Project

General

Profile

Actions

action #44039

closed

/admin/test_suites is broken without login

Added by coolo over 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2018-11-20
Due date:
% Done:

0%

Estimated time:

Description

The page doesn't show a 403 (I guess it should), but just barfs in javascript because:

Uncaught SyntaxError: Unexpected token ,

Actions #1

Updated by coolo over 5 years ago

  • Project changed from openQA Tests to openQA Project
  • Category set to Regressions/Crashes
Actions #2

Updated by mkittler over 5 years ago

I guess it should

I remember doing a ticket which was about making admin pages publicly available in read-only mode. This would revert that effort. Likely fixing the JavaScript error is not a big deal so I'd say fix the error and keep the page publicly accessible.

Actions #3

Updated by okurz over 5 years ago

+1

Actions #4

Updated by kraih over 5 years ago

  • Status changed from New to In Progress

Fixing the JavaScript seems easy enough. There are three more uses of <%= is_admin %> that look really sketchy. Any pointers where a test for this could go?

Actions #5

Updated by coolo over 5 years ago

I guess this is a good oportunity to get familiar with selenium - t/ui/13-admin.t logs in as first step. To test this, there needs to either an extra test file or more subtests before login

Actions #6

Updated by kraih over 5 years ago

  • Status changed from In Progress to Resolved
Actions #7

Updated by coolo almost 5 years ago

  • Target version changed from Ready to Done
Actions

Also available in: Atom PDF