Actions
action #44039
closed/admin/test_suites is broken without login
Description
The page doesn't show a 403 (I guess it should), but just barfs in javascript because:
Uncaught SyntaxError: Unexpected token ,
Updated by coolo about 6 years ago
- Project changed from openQA Tests (public) to openQA Project (public)
- Category set to Regressions/Crashes
Updated by mkittler about 6 years ago
I guess it should
I remember doing a ticket which was about making admin pages publicly available in read-only mode. This would revert that effort. Likely fixing the JavaScript error is not a big deal so I'd say fix the error and keep the page publicly accessible.
Updated by kraih about 6 years ago
- Status changed from New to In Progress
Fixing the JavaScript seems easy enough. There are three more uses of <%= is_admin %> that look really sketchy. Any pointers where a test for this could go?
Updated by coolo about 6 years ago
I guess this is a good oportunity to get familiar with selenium - t/ui/13-admin.t logs in as first step. To test this, there needs to either an extra test file or more subtests before login
Updated by kraih about 6 years ago
- Status changed from In Progress to Resolved
Actions