Project

General

Profile

Actions

action #44009

closed

[sle][migration][SLE15SP1] test fails in yast2_migration - testcase timeout unexpected

Added by leli over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Bugs in existing tests
Target version:
-
Start date:
2018-11-20
Due date:
% Done:

100%

Estimated time:
Difficulty:

Description

Observation

openQA test in scenario sle-15-SP1-Installer-DVD-TEST-x86_64-online_sles15_pscc_basesys+srv_def_full_y@64bit fails in
yast2_migration

Reproducible

Fails since (at least) Build 96.7

Expected result

Last good: (unknown) (or more recent)

Further details

Always latest result in this scenario: latest

Actions #1

Updated by leli over 5 years ago

On investigation, this failure is for the needle yast2-ask-reboot not matched on SLE15. We need clone the job to local and modify code to save the screen to create the needle on local, then submit MR to fix it.

Actions #3

Updated by riafarov over 5 years ago

I've experience similar issue, but even worse, as we have timeout on the pop-up I tried to catch. As of now there is no better way than changing code =(

Actions #4

Updated by mkittler over 5 years ago

So the developer mode wasn't helpful here?

Actions #5

Updated by leli over 5 years ago

Yes, on developer mode I can't create new needle now, I think the create needle should be support on developer mode.

Actions #6

Updated by leli over 5 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 60
Actions #7

Updated by leli over 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 100
Actions #8

Updated by okurz over 5 years ago

  • Status changed from Resolved to In Progress

Hi leli, one problem I see not yet solved though. The job initially failed as incomplete because the sum of the internal timeouts is higher than MAX_JOB_TIME. I suggest to also make sure that MAX_JOB_TIME is high enough, probably in the according testsuite(s)

Actions #9

Updated by leli over 5 years ago

Hi Oliver, this job failed just for the expected needle not matched, it is no relationship with the MAX_JOB_TIME, in fact the default max job time(2h) is enough for this case. We will set enough MAX_JOB_TIME if needed.

Actions #10

Updated by okurz over 5 years ago

sure, I understand why the job failed. The problem with incomplete jobs is that they are hard to review because a label carry over does not work. This is why I suggest to ensure that a high enough MAX_JOB_TIME is used in all test suites

Actions #11

Updated by mkittler over 5 years ago

  • Status changed from In Progress to Workable
  • % Done changed from 100 to 0

@leli

Yes, on developer mode I can't create new needle now

You can put an assert_screen for a non-existent needle in your code. The developer mode allows to pause here (instead of failing) and automatically makes a screenshot to create a new needle from. You can repeat that multiple times in one testrun. Of course you need to adjust the test code manually to add the new assert_screens but the developer mode should still improve the workflow (you don't need to add code to create screenshots).

I think the create needle should be support on developer mode.

What is missing in the developer mode?

Actions #12

Updated by mkittler over 5 years ago

  • Status changed from Workable to In Progress
  • % Done changed from 0 to 100
Actions #13

Updated by okurz over 5 years ago

And with https://github.com/os-autoinst/openQA/pull/1855/files#diff-454b55e3d1e6f1147a46142480c71a85R1251 temporarily adjusting code on production is also even easier :)

Actions #14

Updated by leli over 5 years ago

Status changed from In Progress to Workable
% Done changed from 100 to 0

Comment Edit

@leli

Yes, on developer mode I can't create new needle now

You can put an assert_screen for a non-existent needle in your code. The developer mode allows to pause here (instead of failing) and automatically makes a screenshot to create a new needle from. You can repeat that multiple times in one testrun. Of course you need to adjust the test code manually to add the new assert_screens but the developer mode should still improve the workflow (you don't need to add code to create screenshots).

I think the create needle should be support on developer mode.

What is missing in the developer mode?
@mkittler, in fact, I can clone job and modify code locally to create needle, while this is a bit inconvenient since need submit MR to merge it. If we can add create new needle function on developer mode it will be very helpful for us. Thanks.

Actions #15

Updated by leli over 5 years ago

@okurz, I understand your meaning, while for this incomplete case, increase MAX_JOB_TIME won't help since it will stall there until time out. Thanks for the document for 'temporarily adjusting code ', its very helpful.:)

Actions #16

Updated by okurz over 5 years ago

leli wrote:

@okurz, I understand your meaning, while for this incomplete case, increase MAX_JOB_TIME won't help since it will stall there until time out.

Well, then this is what should be prevented as well then :)

Actions #17

Updated by sunyan over 5 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF