Project

General

Profile

Actions

action #42017

closed

on adding new test scenario in job templates the priority field looks disabled but is not

Added by okurz over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Regressions/Crashes
Target version:
-
Start date:
2018-10-05
Due date:
% Done:

0%

Estimated time:

Description

see attached screenshot, the "prio" up-down-field looks disabled (greyed out) but is not when adding a new test scenario to staging.


Files

Actions #1

Updated by coolo over 5 years ago

the text input is not disabled, but the value is - it's just showing the default value.

@hellcp, have a suggestion for us?

Actions #2

Updated by hellcp over 5 years ago

In cases when there is just one value, which you can't choose, just text is enough, if I understand this correctly.

Actions #3

Updated by coolo over 5 years ago

Sorry, a little background:
On adding a new job template we store NULL as priority, but show the default priority in the UI. Because once you enter something in that text field, this will overwrite the default. So this disabled looking text field is both to show the default and to enter a new one.

Actions #4

Updated by hellcp over 5 years ago

I don't see why it would need to be disabled then, it works like any value selection should :D

Actions #5

Updated by coolo over 5 years ago

It's not disabled - it just looks disabled as we wanted to make the difference between default value and real value clear. That's what this bug is all about :)

Actions #6

Updated by okurz over 5 years ago

coolo wrote:

make the difference between default value and real value clear.

Hm, true. It tricks the eyes thinking the background would be darker if the value is grey and not black but actually the background within the value box is the same in the case of default or overwritten. Well, how about italic text for default?

Actions #7

Updated by mkittler over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

It looks disabled indeed. Here's a PR to use italic font style instead: https://github.com/os-autoinst/openQA/pull/1818

Actions #8

Updated by mkittler over 5 years ago

  • Status changed from In Progress to Resolved

PR has been merged

Actions

Also available in: Atom PDF