action #39227
closedHandle the job being finished more nicely in developer mode
Description
So far the user gets a not so nice error message that the connection to os-autoinst has been lost when the test finishes. Instead, the page should be instantly reloaded.
tasks¶
- Let os-autoinst cmd send a certain message right before it goes down.
- Reload the page when that message has been received.
Updated by mkittler over 5 years ago
- Description updated (diff)
Task 1. is actually tricky to implement because 'right before it goes down' it seems not possible anymore to broadcast one further message to all web socket clients.
Maybe it is better not to stop the command server process directly but to ask it to quit itself via an RPC call. That would allow the command server to extend its livetime to do the last broadcast. If the RPC call fails isotovideo can still stop the process forcefully.
Updated by mkittler over 5 years ago
- Priority changed from Low to Normal
There's the same problem when the job has just been started but the os-autoinst command server isn't available yet. Also in this case the error message shouldn't occur.
Since the error message is annoying and seems to confuse people, I raise the prio back to normal.
Updated by mkittler over 5 years ago
- Status changed from New to In Progress
- Assignee set to mkittler
- Target version set to Current Sprint
I've heard enough complaints about it so I'm adding it the the current sprint.
This PR provides a simpler solution than suggested in the initial ticket: https://github.com/os-autoinst/openQA/pull/1830
The PR just moves the disturbing messages into the developer panel and clears obsolete ones. This is not as nice as the initially proposed solution (which can still be implemented) but already a start.
Updated by mkittler over 5 years ago
Yet another easy improvement to reduce the number of errors: https://github.com/os-autoinst/openQA/commit/7fec2c5382d6b078ac55fe42ab150d7a6cc1a521
Updated by mkittler over 5 years ago
With the latest improvements it is already ok. However, @dheidler noted that the panel is now flickering.
Updated by mkittler over 5 years ago
PR to suppress connection errors before the job has actually started: https://github.com/os-autoinst/openQA/pull/1846
Updated by mkittler over 5 years ago
- Status changed from In Progress to Feedback
- Priority changed from Normal to Low
Not sure whether it is good enough right now. So far I implemented didn't implement the initial idea but did some simpler improvements instead and at least solved the problem mentioned in my 2nd comment. That should at least lower the priority.
Updated by coolo over 5 years ago
- Target version changed from Current Sprint to Done
Updated by mkittler over 5 years ago
- Related to action #45191: developer mode: error message just when clicking "Cancel job" added
Updated by mkittler over 5 years ago
- Status changed from Feedback to Resolved
With https://progress.opensuse.org/issues/45191 we have our feedback. So this error message should be prevented.