QA (public) » openQA Project (public) » openQA Tests (public)

Mentioned feature doesn't allow to set custom message, so requires changes in openQA framework. Additionally, it didn't work for me in other scenario. @okurz, please re-evaluate priority considering mentioned points.

If this feature continues to be useless for us and is not used anywhere in os-autoinst-distri-opensuse you might at least be able to propose deletion again ;) I still see the prio as high because right now it's easier to look into this than later when the bug disappears. Of course, we can try to preserve the older build but then maybe it won't work anymore because the installer changed behaviour and we need to adjust test backwards to be able to test this. Better to take a look now.

Not found any iso in OSD to at least see how it work the mentioned feature.

@JERiveraMoya: Check this PR for more details https://github.com/os-autoinst/os-autoinst/pull/932

You can ask dasantiago who implemented it. Be quick about that to use his limited availability ;)

After debugging with Santiago, feature is working, we realized that we were calling the wrong function, see comment.
local test: http://dhcp254.suse.cz/tests/1640#step/welcome/9

we still need test adaptions for this, not only os-autoinst, right? I would be interested in how the feature in action looks like from the test point of view.

PR in os-autoinst repo still not merged.

@riafarov will create a follow-up ticket about the automatic label.

As explained earlier: I am fine when you want to create another ticket but please make sure to do so because I want to prevent that we consider ourselves done even though the jobs are still making as much review work as in before. When you create a new ticket please also add it to the current sprint as well. I consider this story more important than other tickets as well which we could then postpone.

Yes, thanks for understanding, new ticket has to fall in this sprint, of course, I understand the importance of this ticket to remove tedious work in daily reviews and as a main and final work, it is just a way to account for shippable steps for the team. I will check it with @riafarov (forgot to add it as a watcher) to ensure is in the sprint.

PR merged :)

This needs to be tested better, please add a unit test for this:

https://github.com/os-autoinst/os-autoinst/blob/fdcb65d22c47e2cdd0501532955a120a4b338e97/autotest.pm#L329

take a look at: https://github.com/os-autoinst/os-autoinst/pull/994 for details on how it fails.

@okurz: I've evaluated your suggestion and it's not possible to do that using os-autoinst only, as openQA sets the overall status of the job. I tried to return and stop gracefully, but seems there are some checks on front end side, which fail the job anyway, so will go further with idea of automated comment, or checking if we can soft-fail job with skipped modules.

Ok, makes sense. We could add something to ttm as it already handles commenting on openQA. openqa-review does not