Project

General

Profile

Actions
Copy link

action #36040

closed

[opensuse][functional][u] test fails in shutdown - need a way to check after shutdown needle got matched but shutdown hasn't been executed for unknown reason

Added by zluo over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
oorlov
Category:
Bugs in existing tests
Target version:
SUSE QA (private) - Milestone 19
Start date:
2018-05-09
Due date:
2018-09-25
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

openQA test in scenario opensuse-Tumbleweed-KDE-Live-x86_64-kde-live-wayland@64bit_virtio-2G fails in
shutdown

recent test runs show shutdown issue: shutdown needle matched, but it doesn't got power off, at least I don't see any check for this.

compared with successful run: https://openqa.opensuse.org/tests/668370#step/shutdown/14

I found that logs got collected and after shutdown needle has been matched, it shows up saved screen desktop. And it is somehow passed.

This test run shows matched needle for shutdown and at end the same workflow incl. saved desktop screen. Why this is failed?
question is: how do we know that shutdown is executed successfully, any check on that?

Reproducible

Fails since (at least) Build 20180507

Expected result

Last good: 20180506 (or more recent)

Further details

Always latest result in this scenario: latest

Related issues 1 (0 open — 1 closed)

Related to openQA Tests (public) - coordination #35215: [functional][u][epic][medium] test fails on shutdown moduleResolvedoorlov2018-04-192018-09-25

Actions
Actions
Copy link
 #1

Updated by okurz over 6 years ago

  • Related to coordination #35215: [functional][u][epic][medium] test fails on shutdown module added
Actions
Copy link
 #2

Updated by okurz over 6 years ago

  • Description updated (diff)
  • Due date set to 2018-06-05
  • Priority changed from Normal to High
  • Target version set to Milestone 17

#35215 first, then this one here.

Actions
Copy link
 #3

Updated by riafarov over 6 years ago

  • Related to deleted (coordination #35215: [functional][u][epic][medium] test fails on shutdown module)
Actions
Copy link
 #4

Updated by riafarov over 6 years ago

  • Blocked by coordination #35215: [functional][u][epic][medium] test fails on shutdown module added
Actions
Copy link
 #5

Updated by riafarov over 6 years ago

  • Status changed from New to Blocked

Revisit after issue is fixed for Leap 15 in original ticket.

Actions
Copy link
 #6

Updated by SLindoMansilla over 6 years ago

  • Assignee set to okurz

Please, track the blocking ticket

Actions
Copy link
 #7

Updated by okurz over 6 years ago

  • Due date changed from 2018-06-05 to 2018-07-31
  • Target version changed from Milestone 17 to Milestone 18
Actions
Copy link
 #8

Updated by okurz over 6 years ago

  • Target version changed from Milestone 18 to Milestone 18
Actions
Copy link
 #9

Updated by okurz over 6 years ago

  • Due date changed from 2018-07-31 to 2018-09-25
  • Target version changed from Milestone 18 to Milestone 19
Actions
Copy link
 #10

Updated by oorlov over 6 years ago

  • Status changed from Blocked to Feedback
  • Assignee changed from okurz to oorlov

Last reproduced: https://openqa.opensuse.org/tests/720371#step/shutdown/9

After investigating the logs, I've found that 'Test died: no candidate needle with tag(s) 'sddm_shutdown_option_btn' matched', that is already fixed by PR, but for reboot_plasma5.pm module.

It seems like the workaround should also be removed for the shutdown module.

        if (get_var("PLASMA5")) {
            assert_and_click 'sddm_shutdown_option_btn';
            if (check_screen([qw(sddm_shutdown_option_btn sddm_shutdown_btn)], 3)) {
                # sometimes not reliable, since if clicked the background
                # color of button should changed, thus check and click again
                if (match_has_tag('sddm_shutdown_option_btn')) {
                    assert_and_click 'sddm_shutdown_option_btn';
                }
                # plasma < 5.8
                elsif (match_has_tag('sddm_shutdown_btn')) {
                    assert_and_click 'sddm_shutdown_btn';
                }
            }
        }
Actions
Copy link
 #11

Updated by oorlov over 6 years ago

  • Blocked by deleted (coordination #35215: [functional][u][epic][medium] test fails on shutdown module)
Actions
Copy link
 #12

Updated by oorlov over 6 years ago

  • Is duplicate of action #36150: [opensuse][functional][u][sporadic] test fails in shutdown on unsafe code looking for "sddm_shutdown_option_btn" added
Actions
Copy link
 #13

Updated by oorlov over 6 years ago

  • Is duplicate of deleted (action #36150: [opensuse][functional][u][sporadic] test fails in shutdown on unsafe code looking for "sddm_shutdown_option_btn")
Actions
Copy link
 #14

Updated by oorlov over 6 years ago

  • Related to coordination #35215: [functional][u][epic][medium] test fails on shutdown module added
Actions
Copy link
 #15

Updated by oorlov over 6 years ago

  • Status changed from Feedback to Workable
Actions
Copy link
 #16

Updated by okurz over 6 years ago

So if it is a duplicate then close it as rejected

Actions
Copy link
 #17

Updated by oorlov over 6 years ago

@okurz, After deeper investigation I've realized, that there were two places where the same workaround was applied.

This is why I've reverted the status from 'duplicate' to 'workable'.

I've tried to remove the workaround on my local machine and run 25 jobs, but all of them are failed earlier then they were able to reach 'shutdown' module. The scenario is really flaky.

So, the suggestion from my previous comment might help but it may be not so easy to test it locally, at least on my machine.

Actions
Copy link
 #18

Updated by okurz over 6 years ago

oorlov wrote:

It seems like the workaround should also be removed for the shutdown module.

        if (get_var("PLASMA5")) {
            assert_and_click 'sddm_shutdown_option_btn';
            if (check_screen([qw(sddm_shutdown_option_btn sddm_shutdown_btn)], 3)) {
[…]

Yes, please remove that according to
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5409

I was not aware of that code duplication, not so beautiful ;)

oorlov wrote:

I've tried to remove the workaround on my local machine and run 25 jobs, but all of them are failed earlier then they were able to reach 'shutdown' module. The scenario is really flaky.

I suggest you either make the modules stable or exclude the modules that are unstable and report individual issues about it

Actions
Copy link
 #19

Updated by oorlov over 6 years ago

  • Status changed from Workable to Feedback

The PR was merged. Let's see how tests will run with the changes.

Actions
Copy link

Also available in: Atom PDF