Project

General

Profile

Actions

action #34282

closed

action #34042: [tools] Worker goes to infinite loop during upload of screenshots in case of writing failure

implement catching errors in all our log_* functions

Added by szarate over 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2018-04-05
Due date:
% Done:

0%

Estimated time:

Description

Currently the logging functions that we have in our codebase, do not handle errors in most cases, as they are used everywhere in the code and would prevent cleanup phases from being executed if they fail to print a message.

A fallback to croak or cluck if all else fails would be a good starting point.


Related issues 1 (0 open1 closed)

Has duplicate openQA Project - action #40862: Out of disk space killed the webui (on osd)Rejected2018-09-11

Actions
Actions #1

Updated by EDiGiacinto about 6 years ago

  • Related to action #40862: Out of disk space killed the webui (on osd) added
Actions #2

Updated by coolo about 6 years ago

  • Category set to Regressions/Crashes
  • Priority changed from Normal to High
  • Target version set to Ready

This sounds important enough to handle - we can't be killed by logging

Actions #3

Updated by coolo about 6 years ago

  • Related to deleted (action #40862: Out of disk space killed the webui (on osd))
Actions #4

Updated by coolo about 6 years ago

  • Has duplicate action #40862: Out of disk space killed the webui (on osd) added
Actions #5

Updated by coolo about 6 years ago

  • Target version changed from Ready to Current Sprint

picking it for current sprint

Actions #6

Updated by mkittler about 6 years ago

  • Assignee set to mkittler
Actions #7

Updated by mkittler about 6 years ago

  • Status changed from New to In Progress
Actions #8

Updated by mkittler about 6 years ago

  • Status changed from In Progress to Feedback

PR is merged. Let's see how well it works in production.

Actions #9

Updated by mkittler about 6 years ago

  • Status changed from Feedback to Resolved

Seems like it didn't break anything. If logging fails on production again and my changes turn out to be insufficient we can reopen the ticket.

Actions #10

Updated by coolo almost 6 years ago

  • Target version changed from Current Sprint to Done
Actions

Also available in: Atom PDF