action #34282

action #34042: [tools] Worker goes to infinite loop during upload of screenshots in case of writing failure

implement catching errors in all our log_* functions

Added by szarate almost 2 years ago. Updated about 1 year ago.

Status:ResolvedStart date:05/04/2018
Priority:HighDue date:
Assignee:mkittler% Done:

0%

Category:Concrete Bugs
Target version:Done
Difficulty:
Duration:

Description

Currently the logging functions that we have in our codebase, do not handle errors in most cases, as they are used everywhere in the code and would prevent cleanup phases from being executed if they fail to print a message.

A fallback to croak or cluck if all else fails would be a good starting point.


Related issues

Duplicated by openQA Project - action #40862: Out of disk space killed the webui (on osd) Rejected 11/09/2018

History

#1 Updated by EDiGiacinto over 1 year ago

  • Related to action #40862: Out of disk space killed the webui (on osd) added

#2 Updated by coolo over 1 year ago

  • Category set to Concrete Bugs
  • Priority changed from Normal to High
  • Target version set to Ready

This sounds important enough to handle - we can't be killed by logging

#3 Updated by coolo over 1 year ago

  • Related to deleted (action #40862: Out of disk space killed the webui (on osd))

#4 Updated by coolo over 1 year ago

  • Duplicated by action #40862: Out of disk space killed the webui (on osd) added

#5 Updated by coolo over 1 year ago

  • Target version changed from Ready to Current Sprint

picking it for current sprint

#6 Updated by mkittler over 1 year ago

  • Assignee set to mkittler

#7 Updated by mkittler over 1 year ago

  • Status changed from New to In Progress

#8 Updated by mkittler over 1 year ago

  • Status changed from In Progress to Feedback

PR is merged. Let's see how well it works in production.

#9 Updated by mkittler over 1 year ago

  • Status changed from Feedback to Resolved

Seems like it didn't break anything. If logging fails on production again and my changes turn out to be insufficient we can reopen the ticket.

#10 Updated by coolo about 1 year ago

  • Target version changed from Current Sprint to Done

Also available in: Atom PDF