Project

General

Profile

Actions

coordination #29589

closed

[sle][functional][epic][sle15][hard] Revisit default role and module preselection

Added by riafarov over 6 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Enhancement to existing tests
Start date:
2017-12-19
Due date:
2018-02-13
% Done:

0%

Estimated time:
Difficulty:

Description

User story

As a QA engineer I want to verify that system role is selected according to the modules selection and do not install additional software when installing SLES.

Motivation

With bsc#1056413 resolved we removed the soft-failure needles and removed the record_soft_failure from the test code but we still add the "desktop module" in many places to make our tests comparable to what we did for SLE12. With updated default module selection and a new default system role we should rethink our default for testing as well potentially extend the test coverage to test more module combinations as well as module+role combinations.

Acceptance criteria

  • AC1: Desktop module is not added by default to SLE15 tests
  • AC2: There is at least one test scenario that executes the non-default (e.g. still selecting desktop module)
  • AC3: Test suites still work for SLE 12 SP4 and SLE 15

Tasks

  • read http://bugzilla.suse.com/show_bug.cgi?id=1056413#c21 and compare against our current test default (lib/registration.pm)
  • update test default for SLE15 to SLE15 product default, e.g. "textmode" -> suggestion (okurz): Add a new testsuite "default" for all openSUSE and SLE12+SLE15 instead of "gnome" which does exactly this, the default. "gnome" can then explicitly select the desktop module for SLE15, for SLE12 "gnome" would just be the same as "default" but why not :)
  • add non-default scenarios as explicit additional ones
  • Adjust default_desktop subroutine to return textmode accordingly for SLES15
  • Set DESKTOP variable to gnome explicitly in all scenarios where we expect it
  • Adjust tests to pre-select desktop applications module where required

Further details

The relevant content of c21 in the above bug is:

The following modules should be marked as enabled by default:

SLES:
  - Basesystem Module 
  - Server Applications Module

SLED:
  - Basesystem Module 
  - Desktop Applications Module
  - Desktop Productivity Module

SLES for SAP:
  - Basesystem Module 
  - Server Applications Module
  - High Availability Module
  - SAP Applications Module

Current situation

Since build ~400.4 for SLES basesystem and server applications modules are preselected. This also means that gnome system role is not available for selection and text mode is default. At the moment default desktop is gnome for SLE 15, except minimal installation or installation without registration.


Related issues 2 (0 open2 closed)

Related to openQA Tests - action #29640: [sle][functional] test fails in addon_products_sle - Desktop module and Server module not selected on all-packages-iso scenarioResolvedqmsu2017-12-202018-01-30

Actions
Has duplicate openQA Tests - action #29700: [sle][functional][medium]revisit module preselectionRejected2017-12-212018-01-30

Actions
Actions #1

Updated by okurz over 6 years ago

  • Subject changed from [sle][function][epic] Verify default roles with sle 15 to [sle][functional][epic][sle15] Revisit default role and module preselection
  • Description updated (diff)
  • Due date set to 2018-01-30
  • Target version set to Milestone 13

merge in content from #29700

Actions #2

Updated by okurz over 6 years ago

  • Has duplicate action #29700: [sle][functional][medium]revisit module preselection added
Actions #3

Updated by okurz over 6 years ago

  • Related to action #29640: [sle][functional] test fails in addon_products_sle - Desktop module and Server module not selected on all-packages-iso scenario added
Actions #4

Updated by riafarov over 6 years ago

  • Status changed from New to Workable
  • Assignee set to riafarov
Actions #5

Updated by riafarov over 6 years ago

  • Status changed from Workable to In Progress
Actions #6

Updated by riafarov over 6 years ago

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4249
Missing par is: Add a new testsuite "default" for all openSUSE and SLE12+SLE15 instead of "gnome" which does exactly this, the default. "gnome" can then explicitly select the desktop module for SLE15, for SLE12 "gnome" would just be the same as "default" but why not :)
Which should be reachable by creating test suite without DESKTOP and SYSTEM_ROLE variables set and proper needles.

Actions #7

Updated by riafarov over 6 years ago

  • Status changed from In Progress to Feedback
Actions #9

Updated by mgriessmeier about 6 years ago

  • Status changed from Feedback to In Progress

I guess this failure is related (GNOME pattern missing)
https://openqa.suse.de/tests/1423294#

Actions #10

Updated by mgriessmeier about 6 years ago

also most likely fallout of this PR:
https://openqa.suse.de/tests/1423376#

Actions #12

Updated by okurz about 6 years ago

  • Priority changed from High to Urgent

https://openqa.suse.de/tests/1423627#step/first_boot/5 is another case of maybe unforeseen consequences. The "we-module" test now expects "linux-login" and no gdm anymore.

Actions #13

Updated by okurz about 6 years ago

It's getting more severe, other failures:

maybe we should revert for now and try again?

Actions #14

Updated by riafarov about 6 years ago

  • Priority changed from Urgent to High

I guess reverting is not a bad idea, as there were 2 PRs already and one pending to fix SLES4SAP on SLE12.

Actions #15

Updated by riafarov about 6 years ago

  • Priority changed from High to Urgent
Actions #16

Updated by riafarov about 6 years ago

So all child jobs of create_hdd_gnome are supposed to have DESKTOP set to gnome, I've retriggered those. Problem with wireshark worth discussing if it doesn't belong to DesktopApps.
toolchain_zypper and change_desktop require fixes.

Actions #17

Updated by riafarov about 6 years ago

  • Status changed from In Progress to Feedback

Waiting for the feedback if something got broken. Additionally added desktop for testsuites which have gnome in the name.

Actions #18

Updated by riafarov about 6 years ago

  • Due date changed from 2018-01-30 to 2018-02-13
  • Target version changed from Milestone 13 to Milestone 14
Actions #19

Updated by riafarov about 6 years ago

Check feedback if changes have broken anything else

Actions #20

Updated by riafarov about 6 years ago

  • Subject changed from [sle][functional][epic][sle15] Revisit default role and module preselection to [sle][functional][epic][sle15][hard] Revisit default role and module preselection
  • Status changed from Feedback to Resolved

No additional issues revealed during the last sprint, so resolve. If something pops up later, we fix it for particular corner case.

Actions #21

Updated by szarate over 3 years ago

  • Tracker changed from action to coordination
Actions

Also available in: Atom PDF