Project

General

Profile

Actions
Copy link

action #2564

closed

Implement proper notifications through OBS comments

Added by ancorgs over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
ancorgs
Target version:
Staging sprint 09
Start date:
2014-05-26
Due date:
% Done:

100%

Estimated time:
20.00 h

Description

Now that #2424 is done and we have a prototype able to write and 'remember' comments. We need to implement the comments in a way that makes sense (not spamming) and is useful for users involved in staging projects.

Files

img-529185408-0001.pdf (162 KB) img-529185408-0001.pdf solution idea mlin7442, 2014-05-29 10:57
Actions
Copy link
 #1

Updated by mlin7442 over 10 years ago

hmm...to be honest, I haven't better idea how to "don't spamming", even put all @users in the first comment, they'll still receive the mail once have the other requests add to the same group later, I can't figure out a nice idea...

Actions
Copy link
 #2

Updated by coolo over 10 years ago

yes, but in general I dislike getting more mails than the number of commands were called. E.g. accept should send one mail, and select should send one mail - if you call select multiple times at different time of day, then be it.

Actions
Copy link
 #3

Updated by mlin7442 over 10 years ago

attached my hand-draw idea. have been discuss about it on FT

Actions
Copy link
 #4

Updated by coolo over 10 years ago

So everyone gets one mail with the new summary everytime something changes? I kind of like that.

But I would replace "rq_id xxx @creator" with "Package aaa submitted by @creator" :)

Actions
Copy link
 #5

Updated by coolo over 10 years ago

oops, redmine rendered my markdown - I meant to have it verbatim in the task :)

Actions
Copy link
 #6

Updated by ancorgs over 10 years ago

  • Status changed from New to In Progress
  • Assignee changed from mlin7442 to ancorgs
Actions
Copy link
 #7

Updated by ancorgs over 10 years ago

  • % Done changed from 0 to 70

New comment system implemented following Max plan (one comment per action including only the final result). Waiting for the merge of https://github.com/openSUSE/osc-plugin-factory/pull/154 to commit.

Actions
Copy link
 #8

Updated by ancorgs over 10 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 70 to 100

Finished implementation with tests (including full comments support for the new OBS mockup) https://github.com/openSUSE/osc-plugin-factory/pull/157

Actions
Copy link

Also available in: Atom PDF