Implement proper notifications through OBS comments
Now that #2424 is done and we have a prototype able to write and 'remember' comments. We need to implement the comments in a way that makes sense (not spamming) and is useful for users involved in staging projects.
#1 Updated by mlin7442 almost 9 years ago
hmm...to be honest, I haven't better idea how to "don't spamming", even put all @users in the first comment, they'll still receive the mail once have the other requests add to the same group later, I can't figure out a nice idea...
#2 Updated by coolo almost 9 years ago
yes, but in general I dislike getting more mails than the number of commands were called. E.g. accept should send one mail, and select should send one mail - if you call select multiple times at different time of day, then be it.
#3 Updated by mlin7442 almost 9 years ago
- File img-529185408-0001.pdf img-529185408-0001.pdf added
attached my hand-draw idea. have been discuss about it on FT
#4 Updated by coolo almost 9 years ago
#5 Updated by coolo almost 9 years ago
oops, redmine rendered my markdown - I meant to have it verbatim in the task :)
#6 Updated by ancorgs almost 9 years ago
- Status changed from New to In Progress
- Assignee changed from mlin7442 to ancorgs
#7 Updated by ancorgs almost 9 years ago
- % Done changed from 0 to 70
New comment system implemented following Max plan (one comment per action including only the final result). Waiting for the merge of https://github.com/openSUSE/osc-plugin-factory/pull/154 to commit.
#8 Updated by ancorgs almost 9 years ago
- Status changed from In Progress to Closed
- % Done changed from 70 to 100
Finished implementation with tests (including full comments support for the new OBS mockup) https://github.com/openSUSE/osc-plugin-factory/pull/157