action #17760
closed
Upload .chksum files together with assets
Added by oholecek about 7 years ago.
Updated over 6 years ago.
Category:
Feature requests
Description
For asset caching we need some way of ensuring integrity and that the asset is up to date. At the same time we don't want WebUI to spend time computing checksums.
To solve this we can let worker to upload assets checksum in a separate file as is usual for i.e. distribution of isos.
e.g. - create and upload install_hdd.qcow2 and install_hdd.qcow2.chksum files.
WebUI then must enable distribution of both files.
Who should compute the checksum for the isos?. WebUI? Rsync.pl?
- Precedes action #17574: [tools]Add caching/syncing of assets added
For ISOs it's not soo important, but if we retrigger a job creating a HDD we need to make sure the children get the new HDD. So the worker would download the .chksum first unconditionaly and without caching and then verify what's in the cache.
As HDD checksums are calculated on the worker anyway, I guess I would just do it in the ISO controller when a new ISO is initially posted - unless the caller passes a chksum with it. But that means we need to support multiple checksums IMO - IBS creates sha256 because it's for security, but for HDDs we only care for integrity, so crc would be enough.
So a generic .chksum file with sha256:0fbef344d7ba1ec7da97443b9a1e5b2c2e8312657e701de349a99aee81c9079b or cksum:18307193911 - that would be enough to know if a cache hit is good enough. Or do we want to recalculate the chksum on worker download as well? Then I suggest we ignore the sha256 and calculate CRC in any case.
- Subject changed from Upload .chksum files together with assets to [tools] Upload .chksum files together with assets
- Target version set to Milestone 6
- Assignee deleted (
szarate)
- Target version deleted (
Milestone 6)
Setting to future, as we don't really need this now (superseeded by etag + check of filesize by the cache)
- Subject changed from [tools] Upload .chksum files together with assets to Upload .chksum files together with assets
- Status changed from New to Rejected
So let's assume we don't need this at the moment - for the future we have the more generic #13646
Also available in: Atom
PDF