Project

General

Profile

Actions
Copy link

action #176862

open

coordination #154768: [saga][epic][ux] State-of-art user experience for openQA

coordination #176487: [epic] Up-to-date Perl stack

[beginner][easy] Use Feature::Compat::Try in our code - openQA size:S

Added by okurz 19 days ago. Updated about 16 hours ago.

Status:
In Progress
Priority:
Low
Assignee:
ybonatakis
Category:
Feature requests
Target version:
Ready
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

Like #176475 but for openQA

Acceptance criteria

  • AC1: Automatic checks prevent the use of Try::Tiny in openQA
  • AC2: All basic eval { … }; if ($@) … is replaced by try { … } catch ($e) { } in openQA
  • AC3:: Test::Fatal is not used, and Test::Exception is only used implicitly

Suggestions

Related issues 1 (0 open — 1 closed)

Copied from openQA Project (public) - action #176475: Use Feature::Compat::Try in our code - os-autoinst size:SResolvedokurz2025-02-03

Actions
Actions
Copy link
 #1

Updated by okurz 19 days ago

  • Copied from action #176475: Use Feature::Compat::Try in our code - os-autoinst size:S added
Actions
Copy link
 #2

Updated by okurz 14 days ago

  • Description updated (diff)
  • Status changed from Blocked to New

#176475 successfully resolved.

Actions
Copy link
 #3

Updated by okurz 13 days ago

  • Description updated (diff)
  • Assignee deleted (okurz)
  • Target version changed from Tools - Next to Ready
Actions
Copy link
 #4

Updated by okurz 12 days ago

  • Subject changed from Use Feature::Compat::Try in our code - openQA to [beginner][easy] Use Feature::Compat::Try in our code - openQA
Actions
Copy link
 #5

Updated by okurz 12 days ago

  • Priority changed from Normal to Low
Actions
Copy link
 #6

Updated by ybonatakis 12 days ago

  • Status changed from New to In Progress
  • Assignee set to ybonatakis
Actions
Copy link
 #7

Updated by ybonatakis 11 days ago

https://github.com/os-autoinst/openQA/pull/6183 (wip)
just submitted what have been done so far. not ready for review

Actions
Copy link
 #9

Updated by livdywan 9 days ago

  • Subject changed from [beginner][easy] Use Feature::Compat::Try in our code - openQA to [beginner][easy] Use Feature::Compat::Try in our code - openQA size:S
  • Description updated (diff)
Actions
Copy link
 #10

Updated by ybonatakis 9 days ago

  • Subject changed from [beginner][easy] Use Feature::Compat::Try in our code - openQA size:S to [beginner][easy] Use Feature::Compat::Try in our code - openQA
  • Description updated (diff)

Another one upon all the previous merged PR
https://github.com/os-autoinst/openQA/pull/6194

Actions
Copy link
 #11

Updated by okurz 7 days ago

  • Subject changed from [beginner][easy] Use Feature::Compat::Try in our code - openQA to [beginner][easy] Use Feature::Compat::Try in our code - openQA size:S
  • Description updated (diff)

@ybonatakis please be more careful with ticket updates. I recovered the deleted AC3 and subject addition

Actions
Copy link
 #12

Updated by livdywan 4 days ago

Just to clarify the state https://github.com/os-autoinst/openQA/pull/6183 is being updated now

Actions
Copy link
 #13

Updated by ybonatakis 3 days ago

Splitted commits (from https://github.com/os-autoinst/openQA/pull/6183) into
https://github.com/os-autoinst/openQA/pull/6211
https://github.com/os-autoinst/openQA/pull/6212

PR6212 is not required after all but nice to have??!

Moreover the https://github.com/os-autoinst/openQA/pull/6183 doesnt replace Try::Tiny completely as we decided to handle some modules separated

Actions
Copy link
 #14

Updated by ybonatakis 3 days ago

removed t/deploy.t also from https://github.com/os-autoinst/openQA/pull/6183. it creates confusion

Actions
Copy link
 #15

Updated by ybonatakis 3 days ago

  • Assignee changed from ybonatakis to tinita
Actions
Copy link
 #16

Updated by tinita 3 days ago

Temporarily taking over with https://github.com/os-autoinst/openQA/pull/6206 coverage: Avoid B::Deparse warning with Syntax::Keyword::Try::Deparse

Actions
Copy link
 #17

Updated by tinita 3 days ago

  • Assignee changed from tinita to ybonatakis

https://github.com/os-autoinst/openQA/pull/6206 merged, other PRs can be rebased, assigning back

Actions
Copy link
 #18

Updated by ybonatakis 2 days ago

I did refactor the lib/OpenQA/WebAPI/Controller/API/V1/JobTemplate.pm and tests worked. but I am not sure I have the best solution.
I will think a bit about it before submit.

Actions
Copy link
 #19

Updated by ybonatakis 2 days ago

Oli it would be nice to mention https://github.com/os-autoinst/openQA/pull/6214 here as this one is still in progress.

Actions
Copy link
 #20

Updated by okurz 1 day ago

ybonatakis wrote in #note-19:

Oli it would be nice to mention https://github.com/os-autoinst/openQA/pull/6214 here as this one is still in progress.

sure, it's related. I mentioned the relation in github PRs as well as in meetings. So how about those separate PRs we discussed for the files you saw problematic so that we can offer specific help for each?

Actions
Copy link
 #22

Updated by ybonatakis about 16 hours ago

https://github.com/os-autoinst/openQA/pull/6228

TODO:

  • apply check
  • modify test which uses Try::Tiny
  • not sure but remove try::tiny from deps
Actions
Copy link

Also available in: Atom PDF