Project

General

Profile

Actions

action #1745

closed

Make the accept check permissions to do the tasks

Added by scarabeus_iv almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2014-02-26
Due date:
% Done:

0%

Estimated time:

Description

There are two steps where we need different permissions when accepting the staging.

1) accepting the review for staging group
2) commiting the packages to factory

For first it should just tell you that you can't do it and tell someone else to do it.
For the second it should just let you know some nifty command that you should sent to someone with the privs to run as you don't have them.

Actions #1

Updated by coolo almost 11 years ago

This should be implemented as OBS API though - guessing from clients if you have permissions to do something is going to fail.

Actions #2

Updated by _miska_ almost 11 years ago

  • Assignee set to scarabeus_iv
Actions #3

Updated by scarabeus_iv almost 11 years ago

  • Status changed from New to Resolved

After discussion we agreed that we need permission checking rather on the OBS side and not side-guess it on our side.

I added argument --commit to accept command that allows me to accept the staging group without getting backtrace. So at least kinda this is fixed.

https://github.com/openSUSE/osc-plugin-factory/commit/220f842c5dd53cd2b227b997d1b6d525caedeb72

Actions

Also available in: Atom PDF