Project

General

Profile

Actions
Copy link

action #167938

closed

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #130414: [epic] Improved code coverage in os-autoinst

Cover code of os-autoinst path lockapi.pm fully (statement coverage) size:S

Added by okurz 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Assignee:
gpuliti
Category:
Feature requests
Target version:
Ready
Start date:
2024-10-08
Due date:
% Done:

0%

Estimated time:

Description

Acceptance criteria

  • AC1: the path lockapi.pm is listed in codecov.yml under "fully_covered"

Suggestions

Related issues 2 (0 open — 2 closed)

Copied from openQA Project (public) - action #167935: Cover code of os-autoinst path myjsonrpc.pm fully (statement coverage) size:SResolvedgpuliti2024-10-08

Actions
Copied to openQA Project (public) - action #167941: Cover code of os-autoinst path distribution.pm fully (statement coverage) size:SResolvedgpathak2024-10-08

Actions
Actions
Copy link
 #1

Updated by okurz 5 months ago

  • Copied from action #167935: Cover code of os-autoinst path myjsonrpc.pm fully (statement coverage) size:S added
Actions
Copy link
 #2

Updated by okurz 5 months ago

  • Copied to action #167941: Cover code of os-autoinst path distribution.pm fully (statement coverage) size:S added
Actions
Copy link
 #3

Updated by okurz 5 months ago

  • Parent task changed from #167917 to #130414
Actions
Copy link
 #4

Updated by okurz 3 months ago

  • Subject changed from Cover code of os-autoinst path lockapi.pm fully (statement coverage) size:M to Cover code of os-autoinst path lockapi.pm fully (statement coverage)
Actions
Copy link
 #5

Updated by okurz 3 months ago

  • Target version changed from future to Ready
Actions
Copy link
 #6

Updated by okurz 3 months ago

  • Subject changed from Cover code of os-autoinst path lockapi.pm fully (statement coverage) to Cover code of os-autoinst path lockapi.pm fully (statement coverage) size:S
  • Status changed from New to Workable
Actions
Copy link
 #7

Updated by gpuliti 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to gpuliti

The mutex_wait function not cover is never used, but I think is there for a reason. I'm on it!

Actions
Copy link
 #8

Updated by gpuliti 3 months ago

Created the pull request: https://github.com/os-autoinst/os-autoinst/pull/2590/files

Resolution

I've added a new test in t/30-mmapi.t to cover the mutex_wait function. The test call the mutex_wait and check if the logs are correct.

Actions
Copy link
 #9

Updated by livdywan 3 months ago

  • Status changed from In Progress to Feedback

Acceptance criteria

  • AC1: the path lockapi.pm is listed in codecov.yml under "fully_covered"

Suggestions

Coverage shows as 100%. AC1 looks to be fulfilled?

Actions
Copy link
 #10

Updated by okurz 3 months ago

  • Status changed from Feedback to Resolved

Agreed, done here. Good job!

Actions
Copy link

Also available in: Atom PDF