Actions
action #167938
closedcoordination #127031: [saga][epic] openQA for SUSE customers
coordination #130414: [epic] Improved code coverage in os-autoinst
Cover code of os-autoinst path lockapi.pm fully (statement coverage) size:S
Description
Acceptance criteria¶
- AC1: the path lockapi.pm is listed in codecov.yml under "fully_covered"
Suggestions¶
- Take a look into https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/lockapi.pm about what is missing
- Add unit test statement coverage for that to bump the target
Updated by okurz 4 months ago
- Copied from action #167935: Cover code of os-autoinst path myjsonrpc.pm fully (statement coverage) size:S added
Updated by okurz 4 months ago
- Copied to action #167941: Cover code of os-autoinst path distribution.pm fully (statement coverage) size:S added
Updated by okurz about 2 months ago
- Subject changed from Cover code of os-autoinst path lockapi.pm fully (statement coverage) to Cover code of os-autoinst path lockapi.pm fully (statement coverage) size:S
- Status changed from New to Workable
Updated by gpuliti about 2 months ago
- Status changed from Workable to In Progress
- Assignee set to gpuliti
The mutex_wait function not cover is never used, but I think is there for a reason. I'm on it!
Updated by gpuliti about 2 months ago
Created the pull request: https://github.com/os-autoinst/os-autoinst/pull/2590/files
Resolution¶
I've added a new test in t/30-mmapi.t to cover the mutex_wait function. The test call the mutex_wait and check if the logs are correct.
Updated by livdywan about 2 months ago
- Status changed from In Progress to Feedback
Acceptance criteria¶
- AC1: the path lockapi.pm is listed in codecov.yml under "fully_covered"
Suggestions¶
- Take a look into https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/lockapi.pm about what is missing
Coverage shows as 100%. AC1 looks to be fulfilled?
Updated by okurz about 2 months ago
- Status changed from Feedback to Resolved
Agreed, done here. Good job!
Actions