action #167611
closedcoordination #127031: [saga][epic] openQA for SUSE customers
coordination #165393: [epic] Improved code coverage in openQA
[sporadic] t/ui/21-admin-needles.t fails - Failed test 'search five_month needle correctly' size:S
Description
Observation¶
[04:56:15] t/ui/21-admin-needles.t .................... 17/?
# Failed test 'show all needles'
# at t/ui/21-admin-needles.t line 357.
# got: '3'
# expected: '4'
# Failed test 'search five_month needle correctly'
# at t/ui/21-admin-needles.t line 359.
# got: 'seven_month-undef.json'
# expected: 'five_month.json'
# Looks like you failed 2 tests of 18.
ok 18 - pass invalid IDs to needle deletion route
# Subtest: custom needles search
ok 1 - logged in as demo
# Wait for jQuery successful
ok 2 - 4 added needles shown
ok 3 - do not show last seen custom area
ok 4 - do not show last match custom area
ok 5 - show last seen custom area
# Wait for jQuery successful: custom needle seen "last" range (default 6 months ago)
ok 6 - only show five_month and five_month-undef needles
ok 7 - search five_month needle correctly
ok 8 - search five_month-undef needle correctly
ok 9 - show last match custom area
# Wait for jQuery successful: custom needle seen "last" and match "last" range (default 6 months ago)
ok 10 - only show five_month needle
ok 11 - search needle correctly
# Wait for jQuery successful: custom needle seen "not last" and match "last" range
ok 12 - There is no match needle
# Wait for jQuery successful: custom needle seen "not last" and match "not last" range
ok 13 - show seven_month and seven_month-undef
ok 14 - search seven_month needle correctly
ok 15 - search seven_month-undef needle correctly
# Wait for jQuery successful: "all time" seen and "not last two months" match
not ok 16 - show all needles
not ok 17 - search five_month needle correctly
ok 18 - search five_month-undef needle correctly
1..18
not ok 19 - custom needles search
ok 20 - no (unexpected) warnings (via END block)
Acceptance criteria¶
- AC1: t/ui/21-admin-needles.t passes consistently (in circleCI)
Suggestions:¶
- Call it with
make test KEEP_DB=1 TESTS=t/ui/21-admin-needles.t
to reproduce ormake setup-database
, export PG…,prove -l t/ui/21-admin-needles.t
- Do a code analysis and see where we need proper synchronisation, e.g.
wait_for_element
instead ofwait_for_jquery
- Check whether disabling animations is still effective
- Might be related to recent AJAX related changes
Updated by okurz 7 months ago
- Subject changed from [sporadic] t/ui/21-admin-needles.t fails - Failed test 'search five_month needle correctly' to [sporadic] t/ui/21-admin-needles.t fails - Failed test 'search five_month needle correctly' size:S
- Description updated (diff)
- Category set to Regressions/Crashes
- Status changed from New to Workable
Updated by okurz 6 months ago
- Status changed from Feedback to Resolved
https://github.com/os-autoinst/openQA/pull/5997 merged. I assume that's fine.
Updated by mkittler about 2 months ago
- Status changed from Resolved to In Progress
Looks like this is still not fixed as we got the exact same error again today: https://github.com/os-autoinst/openQA/pull/6277#issuecomment-2710945978
The table is supposed to contain the following rows:
Directory Filename Last Use Last Match
fixtures five_month-undef.json 5 months ago never
fixtures five_month.json 5 months ago 5 months ago
fixtures seven_month-undef.json 7 months ago never
fixtures seven_month.json 7 months ago 7 months ago
I suppose in case of the failure the first or second row is missing. Therefore the number of rows goes down from 4 to 3 and we get seven_month-undef.json
as 2nd row (instead of five_month.json
).
The state of the table as of the previous test section:
Directory Filename Last Use Last Match
fixtures seven_month-undef.json 7 months ago never
fixtures seven_month.json 7 months ago 7 months ago
Then we select "Last Use" -> "All time" ending up with:
Directory Filename Last Use Last Match
fixtures five_month-undef.json 5 months ago never
fixtures seven_month-undef.json 7 months ago never
fixtures seven_month.json 7 months ago 7 months ago
This is most likely the intermediate state we wrongly observe when this test fails. The test actually selects "Last Match" -> "Not last 2 months" but this state is not observed. Probably we need wait_for_data_table
between the state changes.
Updated by mkittler about 2 months ago
- Status changed from In Progress to Feedback
Perhaps the following PR helps: https://github.com/os-autoinst/openQA/pull/6279
Updated by mkittler about 1 month ago
- Status changed from Feedback to Resolved
The PR has been merged.