action #167611
Updated by okurz 2 months ago
### Observation
```
[04:56:15] t/ui/21-admin-needles.t .................... 17/?
# Failed test 'show all needles'
# at t/ui/21-admin-needles.t line 357.
# got: '3'
# expected: '4'
# Failed test 'search five_month needle correctly'
# at t/ui/21-admin-needles.t line 359.
# got: 'seven_month-undef.json'
# expected: 'five_month.json'
# Looks like you failed 2 tests of 18.
```
```
ok 18 - pass invalid IDs to needle deletion route
# Subtest: custom needles search
ok 1 - logged in as demo
# Wait for jQuery successful
ok 2 - 4 added needles shown
ok 3 - do not show last seen custom area
ok 4 - do not show last match custom area
ok 5 - show last seen custom area
# Wait for jQuery successful: custom needle seen "last" range (default 6 months ago)
ok 6 - only show five_month and five_month-undef needles
ok 7 - search five_month needle correctly
ok 8 - search five_month-undef needle correctly
ok 9 - show last match custom area
# Wait for jQuery successful: custom needle seen "last" and match "last" range (default 6 months ago)
ok 10 - only show five_month needle
ok 11 - search needle correctly
# Wait for jQuery successful: custom needle seen "not last" and match "last" range
ok 12 - There is no match needle
# Wait for jQuery successful: custom needle seen "not last" and match "not last" range
ok 13 - show seven_month and seven_month-undef
ok 14 - search seven_month needle correctly
ok 15 - search seven_month-undef needle correctly
# Wait for jQuery successful: "all time" seen and "not last two months" match
not ok 16 - show all needles
not ok 17 - search five_month needle correctly
ok 18 - search five_month-undef needle correctly
1..18
not ok 19 - custom needles search
ok 20 - no (unexpected) warnings (via END block)
```
see https://app.circleci.com/pipelines/github/os-autoinst/openQA/14769/workflows/9e3064c7-df4d-4a48-8fb1-8a48b6796e22/jobs/140478
## Acceptance criteria
* **AC1**: t/ui/21-admin-needles.t passes consistently (in circleCI)
## Suggestions:
* Call it with `make test KEEP_DB=1 TESTS=t/ui/21-admin-needles.t` to reproduce or `make setup-database`, export PG…, `prove -l t/ui/21-admin-needles.t`
* Do a code analysis and see where we need proper synchronisation, e.g. `wait_for_element` instead of `wait_for_jquery`
* Check whether disabling animations is still effective
* Might be related to recent AJAX related changes
Back