Project

General

Profile

Actions

action #167482

closed

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #165393: [epic] Improved code coverage in openQA

[sporadic] codecov checks missing from pull requests size:S

Added by livdywan 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-09-13
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://github.com/os-autoinst/openQA/pull/5944 was merged manually by @livdywan. Because it had been reviewed with all checks shown as passing for several hours.

Notably this shows 42 checks passed. What's missing is codecov for example codecov/patch or codecov/project.

This happens in about 1/20 PRs

Acceptance criteria

  • AC1: os-autoinst+openQA PRs consistently receive codecov reports (probably at least 60 in total)

Suggestions:

  • When checks are missing it probably prevents automatic merging. There is no indication of missing checks, though? Research if that can be made visible.
    • It is visible in the Summary
  • Find out what is causing codecov to be absent. These are started via circleCI jobs.
  • When it happens again, try to quickly check the codecov webhook deliveries, even the successful responses
  • Research or ask in codecov community if that is a known or recurring problem https://github.com/codecov/feedback/

Files

Actions #1

Updated by tinita 3 months ago

Missing checks can be checked by clicking on the "Summary" check. It will show the rules for mergify and tell you which rules are not fulfilled yet

Actions #2

Updated by tinita 3 months ago

  • Description updated (diff)
Actions #3

Updated by livdywan 3 months ago

  • Subject changed from [sporadic] codecov checks missing from pull requests to [sporadic] codecov checks missing from pull requests size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions #4

Updated by okurz 3 months ago

  • Assignee set to ybonatakis
Actions #5

Updated by ybonatakis 2 months ago

  • Status changed from Workable to In Progress
Actions #6

Updated by openqa_review 2 months ago

  • Due date set to 2024-10-22

Setting due date based on mean cycle time of SUSE QE Tools

Actions #7

Updated by okurz 2 months ago

  • Parent task set to #165393
Actions #8

Updated by ybonatakis 2 months ago

The reason can be seen here https://app.codecov.io/gh/os-autoinst/openQA/pull/5944?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=os-autoinst

Missing Head Commit
Unable to compare commits because the head commit was not found

This leads to https://docs.codecov.com/docs/error-reference#section-missing-head-commit where it states

You will see an error stating No coverage uploaded for pull request head. when the pull request has:

- not yet uploaded coverage results to Codecov;
- or the uploaded reports are from failed CI builds.

It might also be that the head commit of the pull request is not found

So checked https://app.circleci.com/pipelines/gh/os-autoinst/openQA/14690/workflows/efc4f8d7-1ecd-4c92-8742-ed90ec81f673/jobs/139558

the main difference between good and bad cases is that
in bad you see something like
Starting create commit process --- {"commit_sha": "b6c7ac4cc198b159179897ac622b46609ccd9c66", "parent_sha": null, "pr": "5944", "branch": "pull/5944", "slug": "os-autoinst/openQA", "token": "0******************", "service": "github", "enterprise_url": null}

while in the good one
Starting create commit process --- {"verbose": true, "auto_load_params_from": null, "codecov_yml_path": null, "enterprise_url": null, "version": "cli-0.7.5", "command": "create-commit", "parent_sha": null, "pull_request_number": "5996", "branch": "pull/5996", "commit_sha": "a9c833c2f8efdc8d40bd45d1df8a95d36eeed804", "fail_on_error": false, "git_service": "github", "slug": "os-autoinst/openQA"}

I cant understand where the difference comes from.
I didnt find anything else in the logs.

Actions #9

Updated by okurz 2 months ago

As we didn't see the issue anymore I suggest you resolve the ticket.

Actions #10

Updated by ybonatakis 2 months ago

The community blog is achieved, so I cant ask there. I filed an issue on codecov/codecov-action
https://github.com/codecov/codecov-action/issues/1606

Actions #11

Updated by ybonatakis 2 months ago

  • Status changed from In Progress to Feedback
Actions #12

Updated by ybonatakis 2 months ago

  • Status changed from Feedback to Blocked
Actions #13

Updated by tinita 2 months ago

ybonatakis wrote in #note-10:

The community blog is achieved, so I cant ask there.

the link to the codecov community is in the ticket description:
https://github.com/codecov/feedback/

Actions #14

Updated by ybonatakis 2 months ago

tinita wrote in #note-13:

ybonatakis wrote in #note-10:

The community blog is achieved, so I cant ask there.

the link to the codecov community is in the ticket description:
https://github.com/codecov/feedback/

So codecov/codecov-action is not the right place to report this?
Do you think I should add it to codecov/feedback/ as well?

Actions #16

Updated by livdywan 2 months ago ยท Edited

  • Status changed from Blocked to Resolved

ybonatakis wrote in #note-15:

PR 6000 :)
https://github.com/os-autoinst/openQA/pull/6000

The codecov config update was deployed. We assume this works. If for any reason we still see it, let's re-open it.

FYI https://github.com/codecov/codecov-action/issues/1606 is still open

Actions #17

Updated by okurz 2 months ago

  • Due date deleted (2024-10-22)
Actions

Also available in: Atom PDF