action #166772
opencoordination #102915: [saga][epic] Automated classification of failures
coordination #166655: [epic] openqa-label-known-issues
[timedbox:10h] openqa-label-known-issues overrides size:S
0%
Description
Observation¶
https://github.com/os-autoinst/scripts/blob/master/openqa-label-known-issues#L55
if ! curl "${curl_args[@]}" -s "$testurl" -o "$out"; then
Problem is that $out is overridden. Then, in case it doesnt reach the block, the script will continue with the label_on_issues_from_issue_tracker with modified context, when it is expected to be the context of autoinst-log.txt.
Raised on https://github.com/os-autoinst/scripts/pull/342/files#r1745228802
Acceptrance criteria¶
- AC1: The output file is written to the right location in the reference function.
Suggestions¶
- Research what the use of the output file is and how to test/verify this
- Try to make sense of the code to find out what the wanted behavior is
- Add unit tests
Updated by ybonatakis about 2 months ago
- Related to action #165716: [o3] Munin - minion hook failed - /opt/os-autoinst-scripts/openqa-label-known-issues: ERROR: line 68 size:M added
Updated by livdywan about 2 months ago
Raised on https://github.com/os-autoinst/scripts/pull/342/files#r1745228802 but i think it is not an issue as the out in the function is a local variable.
What is the goal of this ticket? #166649 covers making the code legible so I wouldn't worry about it here.
Should this be "Complete unit test coverage for openqa-label-known-issues"? Or maybe "Consistent handling of old assets in openqa-label-known-issues"?
Updated by tinita about 2 months ago
but i think it is not an issue as the out in the function is a local variable.
True, but the content of the variable is the filename, passed by the caller, and that stays the same, and so it is overwritten.
Updated by ybonatakis about 2 months ago
livdywan wrote in #note-2:
Raised on https://github.com/os-autoinst/scripts/pull/342/files#r1745228802 but i think it is not an issue as the out in the function is a local variable.
What is the goal of this ticket? #166649 covers making the code legible so I wouldn't worry about it here.
Should this be "Complete unit test coverage for openqa-label-known-issues"? Or maybe "Consistent handling of old assets in openqa-label-known-issues"?
if the ticket needs more info for the estimation, give me some time to investigate and update. sounds good?
Updated by ybonatakis about 2 months ago
- Description updated (diff)
I verified that the autoinst-logs are override and updated the ticket. I also created a draft https://github.com/os-autoinst/scripts/pull/347