action #16538

[easy hack] improve isotovideo command line handling and help

Added by rpalethorpe about 3 years ago. Updated almost 2 years ago.

Status:ResolvedStart date:07/02/2017
Priority:NormalDue date:
Assignee:okurz% Done:

0%

Category:Feature requests
Target version:QA - future
Difficulty:
Duration:

Description

Typing
$ ./isotovideo lsdjf

Only results in:
Can't open 'vars.json' for reading: 'No such file or directory' at qa/os-autoinst/bmwqemu.pm line 72
1672: EXIT 1

There is no warning that a command line parameter has been ignored, this is an issue with the following:
/isotovideo -d /tmp/vars.json

Intuitively I would expect /tmp/vars.json to be used as the test's parameters, instead it is ignored and the following message is returned
Can't open 'vars.json' for reading: 'No such file or directory' at qa/os-autoinst/bmwqemu.pm line 72
1734: EXIT 1

There are a number of possible actions, including:

  • A1, produce an error and help message on an unexpected command line argument
  • A2, treat the first command line argument (which does not start with '-') as the path to vars.json

Obviously A1 and A2 are not mutually exclusive.


Related issues

Related to openQA Project - action #16506: [easy hack] Use of uninitialized value with isotovideo --... Resolved 06/02/2017

History

#1 Updated by okurz about 3 years ago

  • Category set to Feature requests
  • Target version set to future

#2 Updated by okurz about 3 years ago

  • Status changed from New to In Progress
  • Assignee set to okurz

https://github.com/os-autoinst/os-autoinst/pull/725 provides better command line handling and help. A2 is out of scope and I propose to not do it at all as we also provide load_vars() and save_vars() from the testapi and therefore would need to find a way to load/save vars consistently on the same file configuration. Could be done with saving the parameter to isotovideo in a package variable but … meh.

#3 Updated by okurz about 3 years ago

  • Status changed from In Progress to Resolved

PR merged

#4 Updated by dheidler about 3 years ago

  • Related to action #16506: [easy hack] Use of uninitialized value with isotovideo --help added

#5 Updated by okurz almost 2 years ago

  • Target version changed from future to future

Also available in: Atom PDF