Project

General

Profile

Actions

action #164889

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #152847: [epic] version control awareness within openQA for test distributions

Ensure git repos cloned by minions are cleaned up regularly size:S

Added by tinita 4 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

See #162125

In fetchneedles we cleanup the git directory by running git gc. We should do that as well for our new CASEDIR/NEEDLES_DIR git_auto_clone feature.

Acceptance Criteria

  • AC1: The git checkout is regularly cleaned to not use too much space

Suggestions

  • Use git gc to trigger cleanup of the local copy of the repo
  • Wait for #164886

Related issues 3 (0 open3 closed)

Related to openQA Project - action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:MResolvedtinita

Actions
Copied from openQA Project - action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:SResolvedtinita2024-06-12

Actions
Copied to openQA Project - action #165066: Ensure local changes to git repos cloned by git_auto_clone are left alone size:SResolveddheidler2024-08-08

Actions
Actions #1

Updated by tinita 4 months ago

  • Copied from action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:S added
Actions #2

Updated by tinita 4 months ago

  • Description updated (diff)
Actions #3

Updated by tinita 4 months ago

  • Description updated (diff)
Actions #4

Updated by jbaier_cz 4 months ago

  • Target version set to Ready
Actions #5

Updated by tinita 4 months ago

  • Related to action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:M added
Actions #6

Updated by tinita 4 months ago

  • Description updated (diff)
Actions #7

Updated by livdywan 4 months ago

  • Subject changed from Add git gc and diff-index to the minion git clone job to Ensure git repos cloned by minions are cleaned up regularly size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions #8

Updated by livdywan 4 months ago

  • Copied to action #165066: Ensure local changes to git repos cloned by git_auto_clone are left alone size:S added
Actions #9

Updated by robert.richardson 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to robert.richardson
Actions #10

Updated by openqa_review 3 months ago

  • Due date set to 2024-09-03

Setting due date based on mean cycle time of SUSE QE Tools

Actions #11

Updated by robert.richardson 3 months ago

  • Status changed from In Progress to Workable

Setting this back to workable, as i am unavailable until next Wednesday.
Also the merge of #164886 had to be reverted and needs further work.

Actions #12

Updated by livdywan 3 months ago

  • Due date deleted (2024-09-03)
Actions #13

Updated by tinita 3 months ago ยท Edited

  • Assignee deleted (robert.richardson)
  • Target version changed from Ready to Tools - Next

Moving this back into "Next".

Maybe we don't need it as git gc is automatically called for common commands, as @robert.richardson found out.
https://git-scm.com/docs/git-gc#_description
But there might be a reason why we use it in fetchneedles: https://github.com/os-autoinst/openQA/commit/0e7265d4a93c37b672b75d733b73a4fe591e05bf

Actions #14

Updated by robert.richardson 2 months ago

  • Status changed from Workable to Resolved

I've had a short talk with Oli regarding the explicit git gc call. It was introduced solely in order to suppress any output in case the test does not fail, to avoid cron mail spam.
As this special case does not apply for minion jobs and git gc is already called in the background automatically, i would argue the AC is fulfilled.

Actions

Also available in: Atom PDF