Project

General

Profile

Actions

action #163940

closed

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #165393: [epic] Improved code coverage in openQA

Warning in test: SQL::Translator::Diff::schema_diff(): producer_args is deprecated size:S

Added by tinita 9 months ago. Updated 28 days ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
2024-07-15
Due date:
% Done:

0%

Estimated time:

Description

Observation

I've seen this for a while already:
https://app.circleci.com/pipelines/github/os-autoinst/openQA/13997/workflows/82c46d70-704b-4e48-a3ef-76ad4dcb1e30/jobs/131686

[10:08:45] t/deploy.t ................................................ 14/? SQL::Translator::Diff::schema_diff(): producer_args is deprecated -- it does not go straight to the producer, it goes to the internal sqlt object. Please use sqlt_args, which reflects how it's used at /usr/lib/perl5/vendor_perl/5.26.1/DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator.pm line 533

DBIx::Class::DeploymentHandler was last released 5 years ago. I guess we can add a patch in OBS.
https://github.com/frioux/DBIx-Class-DeploymentHandler/issues/77

Acceptance Criteria

  • AC1: circleCI output does not have the warning mentioned in observation
  • AC2: It was ensured that the fixed package version is eventually in current Leap and new Leap in development

Suggestions


Related issues 3 (0 open3 closed)

Related to openQA Project (public) - action #178114: [beginner][openQA][CI] Unhandled output in t/deploy.tResolvedtinita2025-03-01

Actions
Related to openQA Project (public) - action #179008: perl-DBIx-Class-DeploymentHandler not properly linked and documented failing Scripts CI in GitLabResolvedtinita2025-03-17

Actions
Related to openQA Project (public) - action #179131: Tests failing with zypper error about package corrupted during transfer auto_review:"Package perl-DBIx-Class-DeploymentHandler.*seems to be corrupted during transfer"Resolvedokurz

Actions
Actions #1

Updated by okurz 9 months ago

  • Target version set to Ready
Actions #2

Updated by okurz 9 months ago

  • Tags set to reactive work
Actions #4

Updated by tinita 9 months ago

  • Status changed from New to Resolved

The new version is in Factory: https://build.opensuse.org/package/show/openSUSE:Factory/perl-DBIx-Class-DeploymentHandler

So I'd say we are fine, if the deprecated function ever gets removed.

Actions #5

Updated by tinita about 2 months ago

  • Related to action #178114: [beginner][openQA][CI] Unhandled output in t/deploy.t added
Actions #6

Updated by livdywan about 2 months ago

  • Status changed from Resolved to Workable
  • Assignee deleted (tinita)

So as discussed this is still an issue in the context of #178114#note-5 and needs to be re-opened.

Actions #7

Updated by mkittler about 2 months ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions #8

Updated by mkittler about 2 months ago

  • Status changed from In Progress to Feedback

I linked the new version in our devel repos. For Leap 15.5 we would need additional dependencies so I guess at this point we shouldn't put more effort into Leap 15.5. For Leap 15.6 it builds so we should be good. I don't think we need a maintenance update for that because in the worst case one gets a warning and this might not even happen on plain Leap (just on Leap plus our devel repo).

Actions #9

Updated by okurz about 2 months ago · Edited

mkittler wrote in #note-8:

I linked the new version in our devel repos. For Leap 15.5 we would need additional dependencies so I guess at this point we shouldn't put more effort into Leap 15.5.

Where did you find Leap 15.5? 15.5 is EOL. I disabled build in https://build.opensuse.org/project/show/devel:openQA:Leap:15.5 now.

For Leap 15.6 it builds so we should be good.

Please see the note in the project

++++++++++++++++++++ IMPORTANT ++++++++++++++++++

If you add a new package here, please add information why it is needed, which version is needed, and ideally reference a ticket.

++++++++++++++++++++ IMPORTANT ++++++++++++++++++

I don't think we need a maintenance update for that because in the worst case one gets a warning and this might not even happen on plain Leap (just on Leap plus our devel repo).

We should always aim to have devel:openQA:Leap: as minimal as possible hence I see the maintenance update as necessary.

osc sr -m "Update to 0.002234" openSUSE:Factory perl-DBIx-Class-DeploymentHandler openSUSE:Backports:SLE-15-SP6:Update wasn't too hard :)

-> https://build.opensuse.org/requests/1251210

Actions #10

Updated by mkittler about 2 months ago · Edited

Please see the note in the project

I added a comment.

wasn't too hard :)

It could have been that it doesn't build against pure Leap 15.6 (not Leap 15.6 + openQA:devel) so I didn't want to go down that road. And don't you need to provide a Bugzilla reference when creating an MR? (At least I got complains about that before when trying create an MR.)

Actions #12

Updated by okurz about 1 month ago

  • Parent task set to #165393
Actions #13

Updated by tinita about 1 month ago

  • Subject changed from Warning in test: SQL::Translator::Diff::schema_diff(): producer_args is deprecated to Warning in test: SQL::Translator::Diff::schema_diff(): producer_args is deprecated size:S
  • Description updated (diff)
  • Status changed from Blocked to Feedback
  • Parent task deleted (#165393)
Actions #14

Updated by tinita about 1 month ago

  • Status changed from Feedback to Blocked
  • Parent task set to #165393
Actions #15

Updated by tinita about 1 month ago

  • Related to action #179008: perl-DBIx-Class-DeploymentHandler not properly linked and documented failing Scripts CI in GitLab added
Actions #16

Updated by mkittler about 1 month ago

  • Status changed from Blocked to Resolved

The MR was accepted.

Actions #17

Updated by okurz about 1 month ago · Edited

  • Status changed from Resolved to Feedback
  • Assignee changed from mkittler to okurz

but you didn't delete the override from devel:openQA:Leap:15.6. I did that now. Monitoring test results. Triggered https://app.circleci.com/pipelines/github/os-autoinst/openQA/16265/workflows/fd49f5b1-4e89-4dcd-880e-a9381d31a732

Actions #18

Updated by okurz about 1 month ago

https://app.circleci.com/pipelines/github/os-autoinst/openQA/16265/workflows/fd49f5b1-4e89-4dcd-880e-a9381d31a732/jobs/157171 looks clean. Though I don't yet see the updated version released on production systems. Waiting …

Actions #19

Updated by tinita about 1 month ago

  • Blocks action #179017: [obs] os-autoinst t/34-git.t fails in Factory builds added
Actions #20

Updated by tinita about 1 month ago

  • Blocks deleted (action #179017: [obs] os-autoinst t/34-git.t fails in Factory builds)
Actions #21

Updated by okurz about 1 month ago

There seems to be a release request missing so far. Adding package back osc linkpac openSUSE:Factory perl-DBIx-Class-DeploymentHandler devel:openQA:Leap:15.6 with comment

Reason for linking: bugfix

maintenance request to openSUSE:Backports:15-SP6:Update accepted.
Waiting for release request
See https://progress.opensuse.org/issues/163940 for details
Actions #22

Updated by okurz about 1 month ago

  • Status changed from Feedback to In Progress

Now it seems the package is corrupted, e.g. https://openqa.opensuse.org/tests/4931277#step/build/3

Actions #23

Updated by tinita about 1 month ago

  • Related to action #179131: Tests failing with zypper error about package corrupted during transfer auto_review:"Package perl-DBIx-Class-DeploymentHandler.*seems to be corrupted during transfer" added
Actions #24

Updated by livdywan about 1 month ago · Edited

okurz wrote in #note-22:

Now it seems the package is corrupted, e.g. https://openqa.opensuse.org/tests/4931277#step/build/3

I'm not sure the linking could have caused corruption 🤔 as opposed to relating to caching issues (#178642) coinciding with this. So I reported #179131 for now.

Actions #25

Updated by okurz about 1 month ago

  • Status changed from In Progress to Feedback
  • Target version changed from Ready to Tools - Next

#179131 resolved, overlay package stable. Back to waiting for release request

Actions #26

Updated by okurz about 1 month ago

  • Status changed from Feedback to Workable

https://build.opensuse.org/requests/1254339 accepted. Need to check availability in repos

Actions #27

Updated by okurz 28 days ago

  • Status changed from Workable to In Progress
  • Target version changed from Tools - Next to Ready

podman run --rm -it --pull=newer registry.opensuse.org/opensuse/leap sh -c 'zypper ref && zypper se --details -t package DeploymentHandler' says

S  | Name                              | Type    | Version              | Arch   | Repository
---+-----------------------------------+---------+----------------------+--------+----------------------------------------
   | perl-DBIx-Class-DeploymentHandler | package | 0.002234-bp156.4.3.1 | noarch | Update repository of openSUSE Backports
   | perl-DBIx-Class-DeploymentHandler | package | 0.002233-bp156.3.1   | noarch | Main Repository

so the updated package is available. Removing devel:openQA:Leap:15.6 package one again. Retriggered nightly run in circleCI https://app.circleci.com/pipelines/github/os-autoinst/openQA/16402/workflows/cdcbdf71-a393-4269-8570-de070f4c9953

Actions #28

Updated by okurz 28 days ago

  • Status changed from In Progress to Feedback
  • Target version changed from Ready to Tools - Next

https://github.com/os-autoinst/openQA/pull/6334 was created … and it updated perl-Perl-Tidy so not perl-DBIx-Class-DeploymentHandler but that's ok because the version should actually stay even though the build number would change. However I think it's still the old package from some download cache found as https://app.circleci.com/pipelines/github/os-autoinst/openQA/16402/workflows/cdcbdf71-a393-4269-8570-de070f4c9953/jobs/158806/parallel-runs/0/steps/0-104 says that the package comes from devel_openQA. So let's wait

Actions #29

Updated by okurz 28 days ago

  • Status changed from Feedback to Resolved
  • Target version changed from Tools - Next to Ready

https://app.circleci.com/pipelines/github/os-autoinst/openQA/16419/workflows/e69bee72-d328-4ebe-a97d-cbc6762e14f0/jobs/158831 shows that we use

Retrieving: perl-DBIx-Class-DeploymentHandler-0.002234-bp156.4.3.1.noarch (Update repository of openSUSE Backports) (258/264), 126.8 KiB
Actions

Also available in: Atom PDF