Project

General

Profile

Actions

action #162632

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #48641: [epic] Trigger openQA tests in pull requests of any product github pull request

Ensure openqa-clone-custom-git-refspec works fine with git-only test distributions like os-autoinst-distri-openQA size:M

Added by okurz 4 months ago. Updated 23 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2024-06-20
Due date:
% Done:

0%

Estimated time:

Description

Motivation

See error report by Martchus aka. mkittler in https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177#issuecomment-2180542666

Acceptance criteria

  • AC1: openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/<id> https://openqa.opensuse.org/tests/<test_id> yields passing openQA job without needing to set any needles URL specifically for <id> pointing to any PR in that repo and <test_id> pointing to any openQA-in-openQA job. Look up one of those from https://openqa.opensuse.org/group_overview/24
  • AC2: Specifying NEEDLES_DIR as additional argument has precedence
  • AC3: osado can still pass when triggered with openqa-clone-custom-git-refspec which do not use the git URL in their CASEDIR or NEEDLES_DIR without needing explict mentions of NEEDLES_DIR

Suggestions

  • Start with the current test prove -l t/40-script_openqa-clone-custom-git-refspec.t which should be quick enough to execute
  • Look into https://github.com/os-autoinst/openQA/blob/master/script/openqa-clone-custom-git-refspec and how it processes NEEDLES_DIR in particular.
  • Take a look at existing production openSUSE default tests like https://openqa.opensuse.org/tests/4300489 . Those ones have no setting for CASEDIR and no setting for NEEDLES_DIR. After processing vars.json has CASEDIR set to the value of DISTRI and no value for NEEDLES_DIR. In contrast a production openQA-in-openQA job like https://openqa.opensuse.org/tests/4301863 has both DIR variables set to git URLs and vars.json mentions a path like "/var/lib/openqa/pool/13/os-autoinst-needles-openQA" ending up in needing the workaround
  • Read #44327-6 why the vars.json reading was initially included and try at best remove that completely. Maybe we have all the necessary features included by now so that we don't need to do that in openqa-clone-custom-git-refspec

Workaround

  • openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/177 https://openqa.opensuse.org/tests/4285633 NEEDLES_DIR=https://github.com/os-autoinst/os-autoinst-needles-openQA.git
Actions #1

Updated by okurz 4 months ago

  • Tracker changed from coordination to action
Actions #2

Updated by okurz 4 months ago

  • Description updated (diff)
  • Target version changed from Tools - Next to Ready
Actions #3

Updated by okurz 4 months ago

  • Description updated (diff)
Actions #4

Updated by mkittler 3 months ago

  • Subject changed from Ensure openqa-clone-custom-git-refspec works fine with git-only test distributions like os-autoinst-distri-openQA to Ensure openqa-clone-custom-git-refspec works fine with git-only test distributions like os-autoinst-distri-openQA size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #5

Updated by okurz 3 months ago

  • Target version changed from Ready to Tools - Next
Actions #6

Updated by okurz 2 months ago

  • Target version changed from Tools - Next to Ready
Actions #7

Updated by ybonatakis 2 months ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #8

Updated by ybonatakis 2 months ago

Before I submit a PR I would like to ask. replacing .NEEDLES_DIR with .NEEDLES_GIT_URL will not fly for some reason??
https://openqa.opensuse.org/tests/4367939# run successfully as script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4360621.

I just assume that we still need path_to_needles/needles in some cases?

Actions #9

Updated by ybonatakis 2 months ago

ybonatakis wrote in #note-8:

Before I submit a PR I would like to ask. replacing .NEEDLES_DIR with .NEEDLES_GIT_URL will not fly for some reason??
https://openqa.opensuse.org/tests/4367939# run successfully as script/openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-openQA/tree/master https://openqa.opensuse.org/tests/4360621.

I just assume that we still need path_to_needles/needles in some cases?

Got an answer https://openqa.opensuse.org/tests/4368744#details

Actions #10

Updated by ybonatakis 2 months ago

  • Status changed from In Progress to Feedback
Actions #11

Updated by okurz 2 months ago

  • Due date set to 2024-08-13
Actions #12

Updated by ybonatakis 2 months ago

I have updated the PR. As it turns out it was easier to just remove setup of NEEDLES_DIR.

Actions #13

Updated by ybonatakis 2 months ago

  • Status changed from Feedback to Resolved

no respond on eng-testing. Lets see what will break

Actions #14

Updated by okurz 23 days ago

  • Due date deleted (2024-08-13)
Actions

Also available in: Atom PDF