Actions
action #161396
closedopenQA Project - coordination #112862: [saga][epic] Future ideas for easy multi-machine handling: MM-tests as first-class citizens
openQA Project - coordination #111929: [epic] Stable multi-machine tests covering multiple physical workers
gitlab CI jobs do not fail on invalid YAML size:S
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-06-03
Due date:
2024-06-19
% Done:
0%
Estimated time:
Description
Motivation¶
See https://suse.slack.com/archives/C02CANHLANP/p1717381703517509 and #161381 .
As the openqa/workerconf.sls and possibly other files are plain YAML files not using any Jinja templating, we can validate the YAML in a pipeline in merge requests, so a PR with broken YAML will fail and - hopefully - not be merged. We already have the check in the Makefile and we have a CI pipeline but we don't call the check yet in salt pillars on openqa/workerconf.sls even though we treat it as plain YAML file.
Acceptance criteria¶
- AC1: The "workerconf" is checked for YAML validity
Suggestions¶
- We already call yamllint in both salt-states , see https://gitlab.suse.de/openqa/salt-states-openqa/-/jobs/2672309 as example, as well as salt-pillars CI pipelines, see https://gitlab.suse.de/openqa/salt-pillars-openqa/-/jobs/2684395 , but only on files with .ya?ml extension, not *.sls . Try to extend the check for workerconf.sls as we treat it as pure YAML file *or rename the file if we can ensure that it's still usable by salt with a changed name
Actions