action #161396
closed
openQA Project (public) - coordination #112862: [saga][epic] Future ideas for easy multi-machine handling: MM-tests as first-class citizens
openQA Project (public) - coordination #111929: [epic] Stable multi-machine tests covering multiple physical workers
gitlab CI jobs do not fail on invalid YAML size:S
Added by okurz 7 months ago.
Updated 5 months ago.
Category:
Regressions/Crashes
Description
Motivation¶
See https://suse.slack.com/archives/C02CANHLANP/p1717381703517509 and #161381 .
As the openqa/workerconf.sls and possibly other files are plain YAML files not using any Jinja templating, we can validate the YAML in a pipeline in merge requests, so a PR with broken YAML will fail and - hopefully - not be merged. We already have the check in the Makefile and we have a CI pipeline but we don't call the check yet in salt pillars on openqa/workerconf.sls even though we treat it as plain YAML file.
Acceptance criteria¶
- AC1: The "workerconf" is checked for YAML validity
Suggestions¶
- Copied from action #161393: gitlab CI jobs do not execute salt-lint and do not fail on missing "find" executable added
- Description updated (diff)
- Subject changed from gitlab CI jobs do not fail on invalid YAML to gitlab CI jobs do not fail on invalid YAML size:S
- Description updated (diff)
- Status changed from New to Workable
- Status changed from Workable to In Progress
- Assignee set to ybonatakis
- Due date set to 2024-06-20
Setting due date based on mean cycle time of SUSE QE Tools
- Due date deleted (
2024-06-20)
Why did you delete the due date?
- Status changed from In Progress to Feedback
Last PR I think, https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/832
Enables the yamllint checks against *.sls
salt-states-openqa cant be do the same as the sls files as not single yaml (most use templating).
in theory we can configure it and include/exclude the files which yamllint can check but I think ticket focuses on salt-pillars-openqa
tinita wrote in #note-10:
Why did you delete the due date?
I might did it accidentally when I press one of the options which come up when the ticket is already modified while you try to add a comment
As a side note: https://github.com/warpnet/salt-lint/issues/240
Upstream work to implement rule for indentation similar to yamllint. This was the one which breaks mainly in our repo. salt-pillars-openqa should be ok now but salt-states-openqa has still this issue, which you can see when sls are checked by yamllint.
- Copied to action #162044: Ensure proper indentation yamllint checks in our salt-states-openqa+salt-pillars-openqa size:S added
Seems it was fixed by @nick on ac86dba0cc8660a63e7fb8996e19b06883feb809
- Due date set to 2024-06-19
- Status changed from Feedback to Resolved
- Due date deleted (
2024-06-19)
Also available in: Atom
PDF