action #162044
closedopenQA Project (public) - coordination #112862: [saga][epic] Future ideas for easy multi-machine handling: MM-tests as first-class citizens
openQA Project (public) - coordination #111929: [epic] Stable multi-machine tests covering multiple physical workers
Ensure proper indentation yamllint checks in our salt-states-openqa+salt-pillars-openqa size:S
0%
Description
Motivation¶
See
https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/832?commit_id=8412fb44dee81426a40e1f114aed3e62ca7e0667#note_633754
With the merge request we align both repos to use the same YAML style rules but it would be better to explicitly check for indendation. So we should enable indendation check, at best by removing any customization in the yamllint config file, in both salt-states-openqa+salt-pillars-openqa and apply the according necessary style adaptations in both repos.
Acceptance criteria¶
- AC1: Line https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/.yamllint?ref_type=heads#L6 is absent
- AC2: yamllint ensures proper indendation in salt-states-openqa
- AC3: Same as AC1+AC2 but for salt-pillars-openqa
Suggestions¶
- Remove https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/.yamllint?ref_type=heads#L6, call yamllint, see where it fails and adapt the code
- As necessary add a custom rule but at best we can just live with the default
- Apply the same for salt-pillars-openqa
Updated by okurz 6 months ago
- Copied from action #161396: gitlab CI jobs do not fail on invalid YAML size:S added
Updated by livdywan 4 months ago
- Subject changed from Ensure proper indendation yamllint checks in our salt-states-openqa+salt-pillars-openqa to Ensure proper indendation yamllint checks in our salt-states-openqa+salt-pillars-openqa size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by jbaier_cz 4 months ago
Pillars covered by https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/882
Updated by jbaier_cz 4 months ago
- Status changed from In Progress to Feedback
Added https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1255 for salt states and as I used some nice tricks there I also did https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/883 to use them in pillars. After that both repos should use exactly the same rules for linting and CI checking.
Updated by livdywan 4 months ago
jbaier_cz wrote in #note-10:
Added https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1255 for salt states and as I used some nice tricks there I also did https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/883 to use them in pillars. After that both repos should use exactly the same rules for linting and CI checking.
Apparently merging both in order didn't work as I would have expected, hence proposing a revert:
https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/884
Updated by jbaier_cz 4 months ago
livdywan wrote in #note-11:
jbaier_cz wrote in #note-10:
Added https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1255 for salt states and as I used some nice tricks there I also did https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/883 to use them in pillars. After that both repos should use exactly the same rules for linting and CI checking.
Apparently merging both in order didn't work as I would have expected, hence proposing a revert:
https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/884
Quick fix is in https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1257, but I am wondering if this is not a deeper issue as this kind of problem definitely should not happen.
Updated by jbaier_cz 4 months ago
It turned out we really do not have other yaml files in pillars besides .gitlab-ci.yml and that wasn't listed due to missing parenthesis. Fixed in https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1258 with some added verbosity to see what is going on.