action #160430
open
coordination #96596: [qe-core][CI] CI/CD and Coding style improvements
Make dispatch of openQA run dependent on successful compilation
Added by chock about 1 year ago.
Updated 10 days ago.
Description
Currently when opening a PR against os-autoinst it dispatches a test run on openqa.opensuse.org automatically - without waiting for compile or unit checks to complete.
This behavior has two big drawbacks:
- It starts a test that would always fail as long as the PR is in a non-compilable state.
- It would auto-execute code that would potentially be dangerous (VM escapes).
The goal is to fix this behavior in two steps:
- Make the openQA test run depend on the successful compile and unit tests.
- Require maintainer approval for the run.
Files
- Require maintainer approval for the run.
as far as I know approval is already necessary for any new, unknown persons which IMHO is enough
okurz wrote in #note-1:
- Require maintainer approval for the run.
as far as I know approval is already necessary for any new, unknown persons which IMHO is enough
Okay didn't know that. In this case we can drop this requirement.
Better don't trust me but verify that :)
okurz wrote in #note-1:
- Require maintainer approval for the run.
as far as I know approval is already necessary for any new, unknown persons which IMHO is enough
It isn't, otherwise the ticket wouldn't exist.
This is the situation we want to avoid, basically, where openQA tests are triggered by a first-time contributor, but we want the CI checks to work.
Maintainer approval - done
- Need to config github repo settings with environment
manual_approval and add list of approvals on the environment
Dependency between workflows - WIP
-
need to update ci.yml and openQA.yml with import/include workflows in openQA
-
Update ci.yml for workflow_call trigger, openQA.yml with uses etc.
-
Created tested repo ... I am runing and updating jobs, testing
- Status changed from New to In Progress
This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.
Also available in: Atom
PDF