action #160430
opencoordination #96596: [qe-core][CI] CI/CD and Coding style improvements
Make dispatch of openQA run dependent on successful compilation
0%
Description
Currently when opening a PR against os-autoinst it dispatches a test run on openqa.opensuse.org automatically - without waiting for compile or unit checks to complete.
This behavior has two big drawbacks:
- It starts a test that would always fail as long as the PR is in a non-compilable state.
- It would auto-execute code that would potentially be dangerous (VM escapes).
The goal is to fix this behavior in two steps:
- Make the openQA test run depend on the successful compile and unit tests.
- Require maintainer approval for the run.
Files
Checklist
- Make the openQA test run depend on the succesful compile and unit tests
- Require maintainer approval for dispatching the run
Updated by szarate about 2 months ago
okurz wrote in #note-1:
- Require maintainer approval for the run.
as far as I know approval is already necessary for any new, unknown persons which IMHO is enough
It isn't, otherwise the ticket wouldn't exist.
Updated by szarate about 2 months ago
This is the situation we want to avoid, basically, where openQA tests are triggered by a first-time contributor, but we want the CI checks to work.
Updated by luklemes about 2 months ago
Maintainer approval - done
- Need to config github repo settings with environment
manual_approvaland add list of approvals on the environment
Updated by luklemes about 2 months ago
Dependency between workflows - WIP
- need to update ci.yml and openQA.yml with import/include workflows in openQA
Update ci.yml for
workflow_calltrigger,openQA.ymlwithusesetc.Created tested repo ... I am runing and updating jobs, testing