Project

General

Profile

Actions
Copy link

action #160430

open

coordination #96596: [qe-core][CI] CI/CD and Coding style improvements

Make dispatch of openQA run dependent on successful compilation

Added by chock 7 months ago. Updated 7 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
Infrastructure
Target version:
-
Start date:
2024-05-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
easy
Tags:
infra

Description

Currently when opening a PR against os-autoinst it dispatches a test run on openqa.opensuse.org automatically - without waiting for compile or unit checks to complete.
This behavior has two big drawbacks:

  1. It starts a test that would always fail as long as the PR is in a non-compilable state.
  2. It would auto-execute code that would potentially be dangerous (VM escapes).

The goal is to fix this behavior in two steps:

  • Make the openQA test run depend on the successful compile and unit tests.
  • Require maintainer approval for the run.

Files

clipboard-202405211302-dgvfe.png (873 KB) clipboard-202405211302-dgvfe.png szarate, 2024-05-21 11:02
Hide closed

Checklist

  • Make the openQA test run depend on the succesful compile and unit tests
  • Require maintainer approval for dispatching the run
Actions
Copy link
 #1

Updated by okurz 7 months ago

  • Require maintainer approval for the run.

as far as I know approval is already necessary for any new, unknown persons which IMHO is enough

Actions
Copy link
 #2

Updated by chock 7 months ago

okurz wrote in #note-1:

  • Require maintainer approval for the run.

as far as I know approval is already necessary for any new, unknown persons which IMHO is enough

Okay didn't know that. In this case we can drop this requirement.

Actions
Copy link
 #3

Updated by chock 7 months ago

  • Checklist item Require maintainer approval for dispatching the run set to Done
Actions
Copy link
 #4

Updated by okurz 7 months ago

  • Checklist item Require maintainer approval for dispatching the run set to Not done

Better don't trust me but verify that :)

Actions
Copy link
 #5

Updated by szarate 7 months ago

okurz wrote in #note-1:

  • Require maintainer approval for the run.

as far as I know approval is already necessary for any new, unknown persons which IMHO is enough

It isn't, otherwise the ticket wouldn't exist.

Actions
Copy link
 #6

Updated by szarate 7 months ago

This is the situation we want to avoid, basically, where openQA tests are triggered by a first-time contributor, but we want the CI checks to work.

Actions
Copy link
 #7

Updated by luklemes 7 months ago

Maintainer approval - done

  • Need to config github repo settings with environment manual_approval and add list of approvals on the environment
Actions
Copy link
 #8

Updated by luklemes 7 months ago

Dependency between workflows - WIP

  • need to update ci.yml and openQA.yml with import/include workflows in openQA

  • Update ci.yml for workflow_call trigger, openQA.yml with uses etc.

  • Created tested repo ... I am runing and updating jobs, testing

Actions
Copy link
 #9

Updated by luklemes 7 months ago

  • Status changed from New to In Progress
Actions
Copy link

Also available in: Atom PDF