Project

General

Profile

Actions

action #159414

open

Ensure that os-autoinst-setup-multi-machine reliably sets firewall zones not interfering with /etc/sysconfig/network/ifcfg-* size:S

Added by okurz 6 months ago. Updated about 2 months ago.

Status:
Workable
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
2024-03-18
Due date:
% Done:

0%

Estimated time:

Description

https://progress.opensuse.org/issues/159414

Ensure that os-autoinst-setup-multi-machine reliably sets firewall zones not interfering with /etc/sysconfig/network/ifcfg-* size:S

Motivation

As observed in #157414 there is /etc/sysconfig/network/ifcfg-eth0 mentioning ZONE=public and the XML files of firewall mentioning either that or something different. We should ensure that os-autoinst-setup-multi-machine really works with wicked using and writing /etc/sysconfig/network/ifcfg-* and not against it.

Acceptance criteria

  • AC1: os-autoinst-setup-multi-machine ensures that the correct firewall zone is used consistently also after reboot
  • AC1: os-autoinst-setup-multi-machine ensures that the correct firewall zone is used even if /etc/sysconfig/network/ifcfg-* already mentions another zone

Suggestions


Related issues 1 (0 open1 closed)

Copied from openQA Tests - action #157414: Network broken with multimachine on multiple workers (broken packet forwarding / NAT) size:MResolvedmkittler2024-03-182024-05-07

Actions
Actions #1

Updated by okurz 6 months ago

  • Copied from action #157414: Network broken with multimachine on multiple workers (broken packet forwarding / NAT) size:M added
Actions #2

Updated by mkittler 6 months ago

It looks like setup_multi_machine_with_wicked() would already cover the /etc/sysconfig/network/ifcfg-* files - at least for the bridge device. Maybe the need something similar for the ethernet device?

Actions #3

Updated by mkittler 6 months ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

When using the script on aarch64-o3 I could confirm that the zone setting for the ethernet device (in e.g. /etc/sysconfig/network/ifcfg-eth0) is missing, indeed - see #150869#note-15. It was sufficient to simply replace it (after a reboot everything was still configured as expected) so I guess adding sed -i -e 's/ZONE=.*/ZONE=trusted/g' /etc/sysconfig/network/ifcfg-$ethernet to the script would be sufficient. Considering I just did the testing I'll go ahead with that change despite the ticket not being in ready.

Actions #4

Updated by mkittler 6 months ago

  • Status changed from In Progress to New
  • Assignee deleted (mkittler)

Change for wicked: https://github.com/os-autoinst/os-autoinst/pull/2491

I'm unassigning again because we should probably still look into whether we need to cover NetworkManager as well but this ticket isn't in the backlog.

Actions #5

Updated by tinita about 2 months ago

  • Subject changed from Ensure that os-autoinst-setup-multi-machine reliably sets firewall zones not interfering with /etc/sysconfig/network/ifcfg-* to Ensure that os-autoinst-setup-multi-machine reliably sets firewall zones not interfering with /etc/sysconfig/network/ifcfg-* size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions

Also available in: Atom PDF