QA » openQA Project » openQA Tests » qe-yam

Had a look at this. Since in #152005 it looks like the idea wiht "size*" was abandoned it looks like that this ticket is just about removing the autoyast- prefix from the qcow names. This gives us 32 filenames to take care of:

 removed because it was not complete

Digging deeper into this. Its getting worse. We have situations where the first job does a

PUBLISH_HDD_1: 'autoyast-SLES-%VERSION%-%ARCH%-%DESKTOP%-updated.qcow2'

and the chained dependency job uses

HDD_1: 'autoyast-SLES-15-SP5-%ARCH%-%DESKTOP%-updated.qcow2'

so it is practically the same image, but once with %VERSION% and once with 15-SP5 which will make it difficult if we only see for the PUBLISH_HDD_1 names.

And we have anchor imports from test_suites.yaml as well.

So I guess a better filename list will be if I compile the YAML for the support_images job group and then look for all HDD_1 names with autoyast in it, no matter what.

Also note that we have this in support_images:

  sle-15-SP3-Server-DVD-Updates-x86_64:
    - supp_sles15sp3_deregister:
        description: >-
          Create support image for SLES 12SP5 textmode and default patterns.
        <<: *create_hdd_yast_maintenance_desktop
        settings:
          <<: *create_hdd_yast_maintenance_desktop_settings
          DESKTOP: 'textmode'
          INSTALLER_SELF_UPDATE: 'http://download.suse.de/ibs/SUSE:/Maintenance:/Test:/SLE-INSTALLER:/15-SP3:/x86_64/update/'
          PATTERNS: apparmor,base,enhanced_base,minimal_base,yast2_basis
          PUBLISH_HDD_1: autoyast-SLES-15-SP3-%ARCH%-textmode-updated.qcow2
          YAML_SCHEDULE: 'schedule/yast/maintenance/autoyast_create_hdd_maintenance_deregister.yaml'
        testsuite: null

The published HDD is used nowhere in our job groups.

rainerkoenig wrote in #note-5:

Digging deeper into this. Its getting worse. We have situations where the first job does a

PUBLISH_HDD_1: 'autoyast-SLES-%VERSION%-%ARCH%-%DESKTOP%-updated.qcow2'

and the chained dependency job uses

HDD_1: 'autoyast-SLES-15-SP5-%ARCH%-%DESKTOP%-updated.qcow2'

so it is practically the same image, but once with %VERSION% and once with 15-SP5 which will make it difficult if we only see for the PUBLISH_HDD_1 names.

And we have anchor imports from test_suites.yaml as well.

So I guess a better filename list will be if I compile the YAML for the support_images job group and then look for all HDD_1 names with autoyast in it, no matter what.

Also note that we have this in support_images:

  sle-15-SP3-Server-DVD-Updates-x86_64:
    - supp_sles15sp3_deregister:
        description: >-
          Create support image for SLES 12SP5 textmode and default patterns.
        <<: *create_hdd_yast_maintenance_desktop
        settings:
          <<: *create_hdd_yast_maintenance_desktop_settings
          DESKTOP: 'textmode'
          INSTALLER_SELF_UPDATE: 'http://download.suse.de/ibs/SUSE:/Maintenance:/Test:/SLE-INSTALLER:/15-SP3:/x86_64/update/'
          PATTERNS: apparmor,base,enhanced_base,minimal_base,yast2_basis
          PUBLISH_HDD_1: autoyast-SLES-15-SP3-%ARCH%-textmode-updated.qcow2
          YAML_SCHEDULE: 'schedule/yast/maintenance/autoyast_create_hdd_maintenance_deregister.yaml'
        testsuite: null

The published HDD is used nowhere in our job groups.

Agree to use the same naming style for qcow names.
No idea for this test suite, looks like a test suite in development.

Approaching the list of files by extracting them from the compiled YAML for yst_support_images group gives 37 file names with "autoyast" in it:

> grep HDD_1 support-images.yaml | sed 's/^.*HDD_1: //' | grep autoyast | sort | uniq 
autoyast-SLED-%VERSION%-%ARCH%-%DESKTOP%-all_patterns-updated@%MACHINE%.qcow2
autoyast-SLED-%VERSION%-%ARCH%-%DESKTOP%-default_patterns-updated@%MACHINE%.qcow2
autoyast_SLEHPC-%VERSION%-%ARCH%-DEV-gnome-allpatterns-updated.qcow2
autoyast_SLEHPC-%VERSION%-%ARCH%-DEV-gnome-defpatterns-updated.qcow2
autoyast_SLEHPC-%VERSION%-%ARCH%-SERVER-allpatterns-updated.qcow2
autoyast_SLEHPC-%VERSION%-%ARCH%-SERVER-defpatterns-updated.qcow2
autoyast_SLEHPC-%VERSION%-%ARCH%-TEXTMODE-allpatterns-updated.qcow2
autoyast_SLEHPC-%VERSION%-%ARCH%-TEXTMODE-defpatterns-updated.qcow2
autoyast-SLES-12-SP5-aarch64-GM-updated.qcow2
autoyast-SLES-12-SP5-%ARCH%-GM-all_patterns-updated.qcow2
autoyast-SLES-12-SP5-%ARCH%-GM-updated.qcow2
autoyast_SLES-12-SP5-%ARCH%-HA-updated.qcow2
autoyast-SLES-12-SP5-s390x-GM-all_patterns-updated.qcow2
autoyast-SLES-12-SP5-x86_64-GM-media-minimal-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-GM-gnome-allpatterns-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-GM-ltss-%DESKTOP%-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-GM-textmode-allpatterns-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-HA-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-media-minimal-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-textmode-ms-updated.qcow2
autoyast-SLES-15-SP3-%ARCH%-textmode-updated.qcow2
autoyast-SLES-15-SP3-s390x-GM-SDK-gnome-allpatterns.qcow2
autoyast-SLES-15-SP4-%ARCH%-gnome-sdk-allpatterns-updated.qcow2
autoyast-SLES-15-SP4-%ARCH%-HA-updated.qcow2
autoyast-SLES-15-SP4-BUILD%BUILD%-%ARCH%-gnome.qcow2
autoyast-SLES-15-SP5-%ARCH%-%DESKTOP%-updated.qcow2
autoyast-SLES-15-SP5-%ARCH%-GM-HA-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-%DESKTOP%-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-%DESKTOP%-all-patterns-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-%DESKTOP%-all_patterns-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-%DESKTOP%-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-ltss-desktop-%DESKTOP%-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-ltss-%DESKTOP%-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-minimal-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-skip-registration.qcow2
autoyast-SLES-%VERSION%-%ARCH%-GM-updated.qcow2
autoyast-SLES-%VERSION%-%ARCH%-SAP-updated.qcow2

This is a much better starting point.

After obtainting the names to be changed the rest was easy scripting.

MR: https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/116

Current MR doesn't cover the first comment "... following the style of test suite name" (style=name convention). It might have been a AC but I thought it was clear enough, we need quick navigation among the different parts.

Current status: I've iterated through all test suites in the yast_support_images_devel group and adapted the qcow names so that it starts with the name of the job that crates this qcow.

Tried to update all usages of those images as well, but due to %VERSION% and %DESKTOP in the filenames the chances are high that I missed some occurences. This will be fixed in the next round now. We also have occurences in test_suites.yaml which will be difficult to fix, because we should use the correct new name even if it imports a PUBLISH_HDD_1 entry.

Next problem is, that the ticket refers to migration job group, but the replace in files algorithm of VSCode also hit the SLE15 and MU group:

diff --git a/JobGroups/yast_maintenance_updates/x86_64.yaml b/JobGroups/yast_maintenance_updates/x86_64.yaml
index b351768..8d671c2 100644
--- a/JobGroups/yast_maintenance_updates/x86_64.yaml
+++ b/JobGroups/yast_maintenance_updates/x86_64.yaml
@@ -959,7 +959,7 @@ x86_64:
           BOOT_HDD_IMAGE: '1'
           DESKTOP: textmode
           DUD: dev_tools.dud
-          HDD_1: sle-15-SP5-x86_64-GM-textmode_ay@64bit.qcow2
+          HDD_1: supp_sles15sp5_yast-%ARCH%@qcow2
           YAML_SCHEDULE: schedule/yast/generate_dud.yaml
         testsuite: null
     - ncurses_interactive_installation:
diff --git a/JobGroups/SLE_15/aarch64.yaml b/JobGroups/SLE_15/aarch64.yaml
index 40f3965..fe6ed44 100644
--- a/JobGroups/SLE_15/aarch64.yaml
+++ b/JobGroups/SLE_15/aarch64.yaml
@@ -320,7 +320,7 @@ aarch64:
         settings:
           BOOT_HDD_IMAGE: '1'
           BOOTFROM: 'c'
-          HDD_1: openqa_support_server_sles15sp4_aarch64_gnome.qcow2
+          HDD_1: supportserver_generator_from_hdd_desktop-%ARCH%.qcow2
           NICTYPE: tap
           OVS_DEBUG: '1'
           REMOTE_CONTROLLER: vnc
diff --git a/JobGroups/SLE_15/x86_64.yaml b/JobGroups/SLE_15/x86_64.yaml
index 0ce3f2c..4dc0e09 100644
--- a/JobGroups/SLE_15/x86_64.yaml
+++ b/JobGroups/SLE_15/x86_64.yaml
@@ -795,7 +795,7 @@ x86_64:
         settings:
           <<: *gnome_and_qemuram
           BOOT_HDD_IMAGE: '1'
-          HDD_1: openqa_support_server_sles15sp4_x86_64_gnome.qcow2
+          HDD_1: supportserver_generator_from_hdd_gnome-%ARCH%.qcow2
           NICTYPE: tap
           OVS_DEBUG: '1'
           QEMUVGA: cirrus