Project

General

Profile

Actions

action #155713

closed

openQA local tests should work out of the box even if node assets are not yet available size:M

Added by okurz 10 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-02-21
Due date:
% Done:

0%

Estimated time:

Description

Observation

From make test … TESTS=t/43-cli-schedule.t

…
RETRY=0 HOOK=./tools/delete-coverdb-folder timeout -s SIGINT -k 5 -v $((60 * 1 * (0 + 1) ))m tools/retry prove -l --trap  t/43-cli-schedule.t
t/43-cli-schedule.t .. Could not find input asset "../node_modules/datatables.net-bs4/css/dataTables.bootstrap4.min.css". at /usr/lib/perl5/vendor_perl/5.26.1/Mojolicious/Plugin/AssetPack.pm line 172.

this is a regression due to #153427

Acceptance criteria

  • AC1: make test in a clean environment should ensure that all necessary assets are available
  • AC2: Repeated calls to make test use locally available assets and work reasonably quick

Suggestions

  • Consider adding a Makefile target for providing the node modules locally (npm install) and executing that make target as dependency for tests
  • Make sure node_modules is always up to date, because we might add new npm modules or bump versions
  • Or invoke npm install by default as part of the test and other relevant targets (as dependency of them) but ensure it doesn't happen on OBS
  • Ensure we have a clear error message (if there is still a high chance that people will actually see it)
Actions

Also available in: Atom PDF