Project

General

Profile

Actions

action #155713

closed

openQA local tests should work out of the box even if node assets are not yet available size:M

Added by okurz 8 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-02-21
Due date:
% Done:

0%

Estimated time:

Description

Observation

From make test … TESTS=t/43-cli-schedule.t

…
RETRY=0 HOOK=./tools/delete-coverdb-folder timeout -s SIGINT -k 5 -v $((60 * 1 * (0 + 1) ))m tools/retry prove -l --trap  t/43-cli-schedule.t
t/43-cli-schedule.t .. Could not find input asset "../node_modules/datatables.net-bs4/css/dataTables.bootstrap4.min.css". at /usr/lib/perl5/vendor_perl/5.26.1/Mojolicious/Plugin/AssetPack.pm line 172.

this is a regression due to #153427

Acceptance criteria

  • AC1: make test in a clean environment should ensure that all necessary assets are available
  • AC2: Repeated calls to make test use locally available assets and work reasonably quick

Suggestions

  • Consider adding a Makefile target for providing the node modules locally (npm install) and executing that make target as dependency for tests
  • Make sure node_modules is always up to date, because we might add new npm modules or bump versions
  • Or invoke npm install by default as part of the test and other relevant targets (as dependency of them) but ensure it doesn't happen on OBS
  • Ensure we have a clear error message (if there is still a high chance that people will actually see it)
Actions #1

Updated by okurz 8 months ago

  • Priority changed from Normal to Low
Actions #2

Updated by livdywan 7 months ago

  • Subject changed from openQA local tests should work out of the box even if node assets are not yet available to openQA local tests should work out of the box even if node assets are not yet available size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by mkittler 7 months ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions #4

Updated by mkittler 7 months ago

  • Status changed from In Progress to Feedback
Actions #5

Updated by mkittler 7 months ago

  • Status changed from Feedback to Resolved

The PR covering both ACs and adding an improved error message has been merged.

Actions

Also available in: Atom PDF