Actions
action #154762
opencoordination #99303: [saga][epic] Future improvements for SUSE Maintenance QA workflows with fully automated testing, approval and release
coordination #97121: [epic] enable qem-bot comments on IBS (was: enable qa-maintenance/openQABot comments on smelt again)
Refactor qem-bot to use https://github.com/openSUSE/openSUSE-release-tools/blob/master/osclib/comments.py directly instead of bad copy-paste
Start date:
2024-02-01
Due date:
% Done:
0%
Estimated time:
Tags:
Description
Motivation¶
openqabot/osclib/comments.py originally comes from https://github.com/openSUSE/openSUSE-release-tools/blob/master/osclib/comments.py and IMHO should have never been copied to https://gitlab.suse.de/qa-maintenance/openQABot/. We already identified that missing code coverage for comments.py in qem-bot is the cause for reluctance to work on #121228. Instead of solidifying the fork we should use comments.py from upstream openSUSE-release-tools directly.
Suggestions¶
- Delete https://github.com/openSUSE/qem-bot/tree/master/openqabot/osclib and instead refactor https://github.com/openSUSE/qem-bot/ to use https://github.com/openSUSE/openSUSE-release-tools/blob/master/osclib/comments.py directly.
- Adapt run instructions by referencing openSUSE-release-tools
- As necessary adapt https://gitlab.suse.de/qa-maintenance/bot-ng/-/blob/master/.gitlab-ci.yml to also pull in the "openSUSE-release-tools" package which is available in openSUSE or clone the git repo (
time git clone --depth 1 https://github.com/openSUSE/openSUSE-release-toolsonly takes 1s) - Optional provide fixes or improvements to upstream comments.py
Actions