Project

General

Profile

Actions

action #153107

open

coordination #99303: [saga][epic] Future improvements for SUSE Maintenance QA workflows with fully automated testing, approval and release

coordination #97121: [epic] enable qem-bot comments on IBS (was: enable qa-maintenance/openQABot comments on smelt again)

Proper code coverage for at least commenter.py in qem-bot size:M

Added by okurz 9 months ago. Updated 9 months ago.

Status:
Workable
Priority:
Normal
Assignee:
-
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

We would like to provide proper updates about the current approval status of qem-bot in #121228 but the current code coverage within unit tests is insufficient to provide a stable development base so we should provide proper code coverage for at least commenter.py in qem-bot first.

Acceptance criteria

Suggestions

  • Run tests with coverage locally
  • Add tests accordingly and observe the coverage increase
  • Repeat
  • As likely currently the commenter class is not used at all feel free to aggressively refactor
  • Currently the Commenter class is implemented as a subcommand inc-comment and it takes a Namespace argument. As we only want to post comments as part of the inc-approve subcommand, the Commenter class should not implement a subcommand

Related issues 1 (1 open0 closed)

Copied from QA - action #121228: qem-bot comments on IBSNew

Actions
Actions #1

Updated by okurz 9 months ago

Actions #2

Updated by okurz 9 months ago

  • Subject changed from Proper code coverage for at least commenter.py in qem-bot to Proper code coverage for at least commenter.py in qem-bot size:M
  • Description updated (diff)
  • Status changed from New to Workable
  • Target version changed from Ready to future

As discussed in collaborative session 2024-01-04 while this ticket is technically the correct next step to do I am not convinced it provides sufficient Return-on-Invest for the tools team to go further in this direction but rather we should focus on features that benefit more and multiple products and use cases, e.g. where it benefits both Tumbleweed and SLE maintenance tests.

Actions

Also available in: Atom PDF