Project

General

Profile

action #153107

Updated by okurz 9 months ago

## Motivation 
 We would like to provide proper updates about the current approval status of qem-bot in #121228 but the current code coverage within unit tests is insufficient to provide a stable development base so we should provide proper code coverage for at least commenter.py in qem-bot first. 

 ## Acceptance criteria 
 * **AC1:** Significant statement coverage reported in https://app.codecov.io/gh/openSUSE/qem-bot/blob/master/openqabot%2Fcommenter.py (aim for 100%) 

 ## Suggestions 
 * Run tests with coverage locally 
 * Add tests accordingly and observe the coverage increase 
 * Repeat 
 * As likely currently the commenter class is not used at all feel free to aggressively refactor 
 * Currently the Commenter class is implemented as a subcommand `inc-comment` and it takes a `Namespace` argument. As we only want to post comments as part of the `inc-approve` subcommand, the `Commenter` class should not implement a subcommand

Back