Project

General

Profile

Actions
Copy link

action #14934

closed

Show certificate icons for builds where all fails have been labeled but unlabeled softfails are present

Added by okurz about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
mkittler
Category:
Regressions/Crashes
Target version:
-
Start date:
2016-11-22
Due date:
% Done:

0%

Estimated time:

Description

observation

At least the latest build 0058 in
https://openqa.suse.de/group_overview/55 has all fails and incompletes reviewed but no certificate icon shows up
but it works on
https://openqa.suse.de/group_overview/25
because in there we labeled all softfails as a workaround.

steps to reproduce

  • select build with soft ails
  • label all fails (not softfails)
  • observe that the build does not get a certificate icon

problem

https://github.com/os-autoinst/openQA/pull/960/commits/91b28ebe78142a2be3e16565717a1aec07b72853 should have fixed it but did not (commit message is right, content is not).

suggestion

  • Add proper dynamic test data (not all in fixtures)
  • Fix it for good
  • optional: Add orange half-certificate for build with no fails but softfails (compare to all green certificate for auto-review all-passed)
  • optional: Add another icon when all softfails are labeled, too

workaround

label all soft failures, too

Actions
Copy link

Also available in: Atom PDF