action #14934
closedShow certificate icons for builds where all fails have been labeled but unlabeled softfails are present
0%
Description
observation¶
At least the latest build 0058 in
https://openqa.suse.de/group_overview/55 has all fails and incompletes reviewed but no certificate icon shows up
but it works on
https://openqa.suse.de/group_overview/25
because in there we labeled all softfails as a workaround.
steps to reproduce¶
- select build with soft ails
- label all fails (not softfails)
- observe that the build does not get a certificate icon
problem¶
https://github.com/os-autoinst/openQA/pull/960/commits/91b28ebe78142a2be3e16565717a1aec07b72853 should have fixed it but did not (commit message is right, content is not).
suggestion¶
- Add proper dynamic test data (not all in fixtures)
- Fix it for good
- optional: Add orange half-certificate for build with no fails but softfails (compare to all green certificate for auto-review all-passed)
- optional: Add another icon when all softfails are labeled, too
workaround¶
label all soft failures, too
Updated by okurz over 7 years ago
- Blocked by action #14814: Implement tests for parents on index page added
Updated by mkittler over 7 years ago
- Status changed from New to In Progress
Updated by mkittler over 7 years ago
- Blocked by deleted (action #14814: Implement tests for parents on index page)
Updated by okurz over 7 years ago
PR merged. I suggest to either implement the optional ideas in this ticket or reference somewhere else before closing.
Updated by mkittler over 7 years ago
- Priority changed from Urgent to Normal
I think we can keep this open for the optional ideas. However, priority isn't urgent anymore.
Updated by mkittler over 7 years ago
When https://github.com/os-autoinst/openQA/pull/1064 is merged, all optional ideas are implemented, too.
Updated by mkittler over 7 years ago
- Status changed from In Progress to Resolved
Merged and working in production.