Project

General

Profile

Actions

action #14358

closed

updating needles no longer works

Added by coolo about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
-
Start date:
2016-10-21
Due date:
% Done:

0%

Estimated time:

Description

editing a needle and picking old screenshot and old name and try to update the areas you will get an error "Error creating/updating needle: wrong parameters imageversion" instead of the expected "overwrite needle?"

We have no test case for this afaik

Actions #1

Updated by okurz about 8 years ago

keep in mind: https://progress.opensuse.org/projects/openqatests/wiki/Wiki#do-not-overwrite-old-needles-because-old-date-confuses-people
I would not prevent overwriting, though. It might make sense in special cases, especially if it's on the same day which is more likely

Actions #2

Updated by mkittler about 8 years ago

  • Status changed from New to In Progress
  • Assignee set to mkittler
Actions #3

Updated by mkittler about 8 years ago

There is already a test for overriding, so I'll have to check what else could trigger the error.

Improved the test a little bit, though: https://github.com/os-autoinst/openQA/pull/962

Actions #4

Updated by mkittler about 8 years ago

  • Status changed from In Progress to Feedback

Pull request is merged. Test is improved. Does it still happen in production or is it fixed? If not, could you provide more detailed steps to reproduce?

Actions #5

Updated by mkittler about 8 years ago

  • Priority changed from High to Normal

Doesn't seem very important (questions from the last comment remain).

Actions #6

Updated by okurz about 8 years ago

  • Status changed from Feedback to Resolved

I guess it's fixed by the github PR

Actions #7

Updated by coolo about 8 years ago

the PR is just improving the test

Actions #8

Updated by coolo about 8 years ago

but I can't reproduce this at this point. So I will reopen when I see it again

Actions #9

Updated by okurz about 8 years ago

That's what it states but reading the code I see more changes than just adding tests. But feel free to add more steps to reproduce and reopen.

Actions #10

Updated by mkittler about 8 years ago

Other changes are only cleanup.

Actions

Also available in: Atom PDF