Project

General

Profile

Actions

action #134390

closed

coordination #154777: [saga][epic] Shareable os-autoinst and test distribution plugins

coordination #108527: [epic] os-autoinst wheels for scalable code reuse of helper functions and segmented test distributions

Log proactively where wheel components are located to ease debugging size:M

Added by livdywan over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Feature requests
Target version:
Start date:
2023-06-01
Due date:
% Done:

0%

Estimated time:

Description

Motivation

When working on a wheel the folder structure is very important. In practice when the import of a function from a module contained in a wheel doesn't work one will end up with verbose Perl errors without knowing exactly where os-autoinst was trying to import from.

Acceptance Criteria

  • AC1: It is possible to specify a local wheels directory for development purposes.
  • AC2: Used wheel paths are logged in a way that is useful for debugging.

Suggestions

  • Support arbitrary paths in wheels.yaml (maybe not the best idea but checking whether a local path was specified before cloning from Git would not hurt)
  • Allow users to specify the local toplevel wheel path used for all wheels (instead of the pool dir)
  • Check whether the WHEELS_DIR variable can be used

Related issues 1 (0 open1 closed)

Copied from openQA Project (public) - action #130369: [spike][timeboxed:20h] Reduce duplication of openQA-in-openQA tests in os-autoinst-distri-opensuse and os-autoinst-distri-openQA size:SResolvedtinita2023-06-01

Actions
Actions #1

Updated by livdywan over 1 year ago

  • Copied from action #130369: [spike][timeboxed:20h] Reduce duplication of openQA-in-openQA tests in os-autoinst-distri-opensuse and os-autoinst-distri-openQA size:S added
Actions #2

Updated by livdywan over 1 year ago

  • Subject changed from Log proactively where wheel components are located to ease debugging to Log proactively where wheel components are located to ease debugging size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by livdywan over 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to livdywan

Looking into logging and re-considering the wheels dir logic in a collaborative session. Draft to follow soon!

Actions #5

Updated by openqa_review over 1 year ago

  • Due date set to 2023-09-08

Setting due date based on mean cycle time of SUSE QE Tools

Actions #6

Updated by livdywan over 1 year ago

  • Status changed from In Progress to Feedback

livdywan wrote in #note-4:

https://github.com/os-autoinst/os-autoinst/pull/2356

Ideally this PR addresses both AC's. WHEELS_DIR is now in fact where wheels are being checked out to, and can be a local folder managed by a developer - before it were always checked out in the pool dir which is not persistent. Logging with regard to errors and cloning of wheels is also more explicit now.

Actions #7

Updated by livdywan about 1 year ago

  • Due date changed from 2023-09-08 to 2023-09-15

livdywan wrote in #note-6:

livdywan wrote in #note-4:

https://github.com/os-autoinst/os-autoinst/pull/2356

Ideally this PR addresses both AC's. WHEELS_DIR is now in fact where wheels are being checked out to, and can be a local folder managed by a developer - before it were always checked out in the pool dir which is not persistent. Logging with regard to errors and cloning of wheels is also more explicit now.

All of that has been discussed with several people in the team and implemented in the meanwhile. It took a bit longer as making the unit tests work was not trivial. Ideally it will be approved and deployed today, and we can monitor over next week to ensure there's no surprises.

Actions #8

Updated by okurz about 1 year ago

  • Priority changed from Normal to High

Considering that this in line blocks many tickets I would like to bump prio

Actions #9

Updated by okurz about 1 year ago

Right now blocked by #135632

Actions #10

Updated by livdywan about 1 year ago

  • Due date deleted (2023-09-15)
  • Status changed from Feedback to Blocked
Actions #11

Updated by livdywan about 1 year ago

  • Status changed from Blocked to Feedback
Actions #12

Updated by okurz about 1 year ago

Please provide example log output, then we can resolve

Actions #13

Updated by tinita about 1 year ago

  • Status changed from Feedback to Resolved

https://openqa.opensuse.org/tests/3604799/logfile?filename=autoinst-log.txt

[2023-09-28T12:54:20.075229+02:00] [info] [pid:53177] ::: OpenQA::Isotovideo::Utils::clone_git: Cloning git URL 'https://github.com/os-autoinst/os-autoinst-wheel-launcher.git' into '/var/lib/openqa/pool/25'
[2023-09-28T12:54:20.544741+02:00] [debug] [pid:53177] Cloning into 'os-autoinst-wheel-launcher'...

So it tells us into which directory it will be cloned.

@livdywan and I think it can be resolved.

Actions

Also available in: Atom PDF